Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 543403003: Improve <textarea> validation performance. (Closed)

Created:
6 years, 3 months ago by tkent
Modified:
6 years, 3 months ago
Reviewers:
keishi
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, mlamouri (slow - plz ping)
Project:
blink
Visibility:
Public.

Description

Improve <textarea> validation performance. HTMLTextAreaElement::value() is a costly operation, and we can avoid it if a <textarea> has neither 'required' attribute nor 'maxlength' attribute. This CL improves PerformanceTests/DOM/textarea-dom.html and textarea-edit.html by a few percent. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181785

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M Source/core/html/HTMLTextAreaElement.h View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTextAreaElement.cpp View 2 chunks +12 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
tkent
Please review this.
6 years, 3 months ago (2014-09-09 23:49:37 UTC) #4
keishi
lgtm
6 years, 3 months ago (2014-09-11 03:04:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/543403003/20001
6 years, 3 months ago (2014-09-11 03:05:01 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 03:08:10 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as 181785

Powered by Google App Engine
This is Rietveld 408576698