pkg/analysis_server/test/services/completion/completion_computer_test.dart - Issue 543393002: improve keyword suggestions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/services/completion/completion_computer_test.dart

Issue 543393002: improve keyword suggestions (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/keyword_computer.dart ('k') | pkg/analysis_server/test/services/completion/keyword_computer_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/services/completion/completion_computer_test.dart

diff --git a/pkg/analysis_server/test/services/completion/completion_computer_test.dart b/pkg/analysis_server/test/services/completion/completion_computer_test.dart

index 599f40a7b9f04847f44effc092ff33f5889bab30..30b0afc55ec1c751e75c29d7c4e90d3052efaa12 100644

--- a/pkg/analysis_server/test/services/completion/completion_computer_test.dart

+++ b/pkg/analysis_server/test/services/completion/completion_computer_test.dart

@@ -61,7 +61,7 @@ class DartCompletionManagerTest extends AbstractSingleUnitTest {

index = createLocalMemoryIndex();

searchEngine = new SearchEngineImpl(index);

source = addSource('/does/not/exist.dart', '');

- manager = new DartCompletionManager(context, searchEngine, source, 17);

+ manager = new DartCompletionManager(context, searchEngine, source, 0);

suggestion1 = new CompletionSuggestion(

CompletionSuggestionKind.CLASS,

CompletionRelevance.DEFAULT,

@@ -89,8 +89,8 @@ class DartCompletionManagerTest extends AbstractSingleUnitTest {

manager.results().listen((CompletionResult r) {

switch (++count) {

case 1:

- computer1.assertCalls(context, source, 17, searchEngine);

- computer2.assertCalls(context, source, 17, searchEngine);

+ computer1.assertCalls(context, source, 0, searchEngine);

+ computer2.assertCalls(context, source, 0, searchEngine);

expect(r.last, isFalse);

expect(r.suggestions, hasLength(1));

expect(r.suggestions, contains(suggestion1));

@@ -125,8 +125,8 @@ class DartCompletionManagerTest extends AbstractSingleUnitTest {