components/nacl/loader/nonsfi/nonsfi_sandbox.cc - Issue 543333002: bpf_dsl: fix argument-dependent lookup of BoolExpr operators

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/loader/nonsfi/nonsfi_sandbox.cc

Issue 543333002: bpf_dsl: fix argument-dependent lookup of BoolExpr operators (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/nacl/loader/nonsfi/nonsfi_sandbox.cc

diff --git a/components/nacl/loader/nonsfi/nonsfi_sandbox.cc b/components/nacl/loader/nonsfi/nonsfi_sandbox.cc

index b5fe899746c3bc7a70b62193ccc693766e917216..0496c1f8ec0c30e40ee0a0b82c5394775df85970 100644

--- a/components/nacl/loader/nonsfi/nonsfi_sandbox.cc

+++ b/components/nacl/loader/nonsfi/nonsfi_sandbox.cc

@@ -37,11 +37,6 @@ using sandbox::bpf_dsl::Error;

using sandbox::bpf_dsl::If;

using sandbox::bpf_dsl::ResultExpr;

-// TODO(mdempsky): Make BoolExpr a standalone class so these operators can

-// be resolved via argument-dependent lookup.

-using sandbox::bpf_dsl::operator&&;

-using sandbox::bpf_dsl::operator||;

namespace nacl {

namespace nonsfi {

namespace {

« no previous file with comments | « no previous file | sandbox/linux/bpf_dsl/bpf_dsl.h » ('j') | no next file with comments »