Remove CreateArrayLiteralShallow

src/objects.cc

Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index f7c89175da75c2fb7916015a34adf9954b565eef..79dd91ab84d3b96f27d7722a634749ab1d5127da 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -5836,14 +5836,7 @@ Handle<JSObject> JSObjectWalkVisitor::StructureWalk(Handle<JSObject> object) {
     case FAST_HOLEY_SMI_ELEMENTS:
     case FAST_HOLEY_ELEMENTS: {
       Handle<FixedArray> elements(FixedArray::cast(copy->elements()));
-      if (elements->map() == isolate->heap()->fixed_cow_array_map()) {
-        isolate->counters()->cow_arrays_created_runtime()->Increment();

[Michael Starzinger, 2013/11/04 14:12:03]

This removes the accounting of cloned CoW arrays in nested object structures. Is
that on purpose? I think we should leave this accounting intact as it currently
is and instead remove the special-casing in Runtime_CreateArrayLiteral that just
accounts for the outermost object in nested structures.

[mvstanton, 2013/11/04 14:47:15]

Thanks, I was trying to avoid double counting but made a mistake. I've just
ensured the increment runs if we are doing a copying visit through the object.

-#ifdef DEBUG
-        for (int i = 0; i < elements->length(); i++) {
-          ASSERT(!elements->get(i)->IsJSObject());
-        }
-#endif
-      } else {
+      if (elements->map() != isolate->heap()->fixed_cow_array_map()) {
         for (int i = 0; i < elements->length(); i++) {
           Handle<Object> value(elements->get(i), isolate);
           ASSERT(value->IsSmi() ||