Remove CreateArrayLiteralShallow

Remove CreateArrayLiteralShallow, as it's fundamentally the same now as
CreateArrayLiteral.

R=mstarzinger@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=17470

[mvstanton, 2013-10-31 13:20:25]

Hi Michael, we chatted about this earlier, PTAL, thx!
--Michael

[Michael Starzinger, 2013-11-04 14:12:03]

Looking good, love this simplification. Just one comment.

https://codereview.chromium.org/54333003/diff/1/src/objects.cc
File src/objects.cc (left):

https://codereview.chromium.org/54333003/diff/1/src/objects.cc#oldcode5840
src/objects.cc:5840:
isolate->counters()->cow_arrays_created_runtime()->Increment();
This removes the accounting of cloned CoW arrays in nested object structures. Is
that on purpose? I think we should leave this accounting intact as it currently
is and instead remove the special-casing in Runtime_CreateArrayLiteral that just
accounts for the outermost object in nested structures.

https://codereview.chromium.org/54333003/diff/1/src/runtime.cc
File src/runtime.cc (right):

https://codereview.chromium.org/54333003/diff/1/src/runtime.cc#newcode571
src/runtime.cc:571:
isolate->counters()->cow_arrays_created_runtime()->Increment();
See comments in objects.cc about this.

[mvstanton, 2013-11-04 14:47:15]

Thx for the comments, updated, along with a test.
--Michael

https://codereview.chromium.org/54333003/diff/1/src/objects.cc
File src/objects.cc (left):

https://codereview.chromium.org/54333003/diff/1/src/objects.cc#oldcode5840
src/objects.cc:5840:
isolate->counters()->cow_arrays_created_runtime()->Increment();
On 2013/11/04 14:12:03, Michael Starzinger wrote:
> This removes the accounting of cloned CoW arrays in nested object structures.
Is
> that on purpose? I think we should leave this accounting intact as it
currently
> is and instead remove the special-casing in Runtime_CreateArrayLiteral that
just
> accounts for the outermost object in nested structures.

Thanks, I was trying to avoid double counting but made a mistake. I've just
ensured the increment runs if we are doing a copying visit through the object.

https://codereview.chromium.org/54333003/diff/1/src/runtime.cc
File src/runtime.cc (right):

https://codereview.chromium.org/54333003/diff/1/src/runtime.cc#newcode571
src/runtime.cc:571:
isolate->counters()->cow_arrays_created_runtime()->Increment();
On 2013/11/04 14:12:03, Michael Starzinger wrote:
> See comments in objects.cc about this.

Right on, removed this code.

[Michael Starzinger, 2013-11-04 14:54:08]

LGTM.

[mvstanton, 2013-11-05 09:55:12]

Committed patchset #2 manually as r17470 (presubmit successful).