Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 543263002: Move ContentAppModelBuilder to athena/extensions. (Closed)

Created:
6 years, 3 months ago by Jun Mukai
Modified:
6 years, 3 months ago
Reviewers:
xiyuan, Yoyo Zhou, oshima, tony
CC:
chromium-reviews, darin-cc_chromium.org, jam, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move ContentAppModelBuilder to athena/extensions. The AppModelBuilder does not rely on content so much, rather it's highly related to the extension system. Therefore, it's better to be in athena/extensions, and its name should be ExtensionAppModelBuilder instead. This will simplifies DEPS rules of athena/content. BUG=None R=oshima@chromium.org TBR=yoz@chromium.org, xiyuan@chromium.org, tony@chromium.org TEST=build Committed: https://crrev.com/1fed1b5fe736ea42a505a0b54445e86f8f195f33 Cr-Commit-Position: refs/heads/master@{#294011}

Patch Set 1 #

Patch Set 2 : remove entries from athena/extensions/chrome/DEPS #

Patch Set 3 : DEPS fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -185 lines) Patch
M athena/athena.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M athena/content/DEPS View 2 chunks +6 lines, -5 lines 0 comments Download
M athena/content/chrome/DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
D athena/content/content_app_model_builder.cc View 1 chunk +0 lines, -130 lines 0 comments Download
D athena/content/public/content_app_model_builder.h View 1 chunk +0 lines, -32 lines 0 comments Download
M athena/extensions/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
M athena/extensions/chrome/DEPS View 1 1 chunk +0 lines, -2 lines 0 comments Download
A + athena/extensions/extension_app_model_builder.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + athena/extensions/public/extension_app_model_builder.h View 2 chunks +7 lines, -7 lines 0 comments Download
M athena/main/athena_launcher.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (8 generated)
Jun Mukai
6 years, 3 months ago (2014-09-05 23:18:40 UTC) #1
oshima
nice. can you clean up a/e/chrome/DEPS and a/e/shell/DEPS? then lgtm
6 years, 3 months ago (2014-09-06 00:19:04 UTC) #2
Jun Mukai
On 2014/09/06 00:19:04, oshima wrote: > nice. > > can you clean up a/e/chrome/DEPS and ...
6 years, 3 months ago (2014-09-06 00:43:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/543263002/20001
6 years, 3 months ago (2014-09-06 00:43:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/9152)
6 years, 3 months ago (2014-09-06 01:03:03 UTC) #7
Jun Mukai
TBR for the OWNERS of moved DEPS entries
6 years, 3 months ago (2014-09-06 01:30:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/543263002/20001
6 years, 3 months ago (2014-09-06 01:32:02 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/12516) ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/builds/12444) ios_rel_device_ninja ...
6 years, 3 months ago (2014-09-06 01:55:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/543263002/20001
6 years, 3 months ago (2014-09-09 17:42:44 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/8971)
6 years, 3 months ago (2014-09-09 17:50:29 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/543263002/40001
6 years, 3 months ago (2014-09-09 20:14:21 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 2d8d918ed36cac532e6139482eab843bf07583ea
6 years, 3 months ago (2014-09-09 21:27:19 UTC) #20
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:55:43 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1fed1b5fe736ea42a505a0b54445e86f8f195f33
Cr-Commit-Position: refs/heads/master@{#294011}

Powered by Google App Engine
This is Rietveld 408576698