Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/telemetry/telemetry/page/page_runner.py

Issue 543243002: Drop DidStartHTTPServer to simplify object interactions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/perf/measurements/page_cycler.py ('K') | « tools/perf/measurements/page_cycler.py ('k') | tools/telemetry/telemetry/page/page_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/page_runner.py
diff --git a/tools/telemetry/telemetry/page/page_runner.py b/tools/telemetry/telemetry/page/page_runner.py
index 9b55958f79d7a26e85dfa529773152c08d8577b2..c8f61f34d55272cfc22dcc440ae86a3e88e8885e 100644
--- a/tools/telemetry/telemetry/page/page_runner.py
+++ b/tools/telemetry/telemetry/page/page_runner.py
@@ -151,10 +151,8 @@ class PageState(object):
def PreparePage(self, test=None):
if self.page.is_file:
- server_started = self.tab.browser.SetHTTPServerDirectories(
- self.page.page_set.serving_dirs | set([self.page.serving_dir]))
- if server_started and test:
- test.DidStartHTTPServer(self.tab)
+ self.tab.browser.SetHTTPServerDirectories(
+ self.page.page_set.serving_dirs | set([self.page.serving_dir]))
if self.page.credentials:
if not self.tab.browser.credentials.LoginNeeded(
« tools/perf/measurements/page_cycler.py ('K') | « tools/perf/measurements/page_cycler.py ('k') | tools/telemetry/telemetry/page/page_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698