Chromium Code Reviews| Index: components/wifi.gypi |
| diff --git a/components/onc.gypi b/components/wifi.gypi |
| similarity index 61% |
| copy from components/onc.gypi |
| copy to components/wifi.gypi |
| index 2ac52c57b014993006f3bb39cfaebea2b8658434..f65bdaa5981f1f19da7c154400106d10ed066673 100644 |
| --- a/components/onc.gypi |
| +++ b/components/wifi.gypi |
| @@ -5,21 +5,23 @@ |
| { |
| 'targets': [ |
| { |
| - 'target_name': 'onc_component', |
| + 'target_name': 'wifi_component', |
| 'type': '<(component)', |
| 'dependencies': [ |
| '../base/base.gyp:base', |
| + '../components/components.gyp:onc_component', |
|
tfarina
2014/04/18 15:30:37
also, this path is "wrong", you don't need to go u
tfarina
2014/04/18 15:35:17
just 'onc_component' also works, because you are i
mef
2014/04/18 15:38:25
sgtm, I'll do that.
|
| ], |
| 'include_dirs': [ |
| '..', |
| ], |
| 'defines': [ |
| - 'ONC_IMPLEMENTATION', |
| + 'WIFI_IMPLEMENTATION', |
| ], |
| 'sources': [ |
| - 'onc/onc_constants.cc', |
| - 'onc/onc_constants.h', |
| - 'onc/onc_export.h', |
| + 'wifi/wifi_export.h', |
| + 'wifi/wifi_service.cc', |
| + 'wifi/wifi_service.h', |
| + 'wifi/fake_wifi_service.cc', |
|
tfarina
2014/04/18 00:46:54
this is including test code in production code.
mef
2014/04/18 14:57:40
Should I move it to //src/chrome/browser/extension
tfarina
2014/04/18 15:28:07
either that or what I have initially thought in do
mef
2014/04/18 15:38:25
Sounds good, I'll do that
|
| ], |
| }, |
| ], |