Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Side by Side Diff: components/wifi.gypi

Issue 54323003: Base infrastructure for Networking Private API on Windows and Mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sync up to r236620 Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « components/components.gyp ('k') | components/wifi/DEPS » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'targets': [ 6 'targets': [
7 { 7 {
8 'target_name': 'onc_component', 8 'target_name': 'wifi_component',
9 'type': '<(component)', 9 'type': '<(component)',
10 'dependencies': [ 10 'dependencies': [
11 '../base/base.gyp:base', 11 '../base/base.gyp:base',
12 '../components/components.gyp:onc_component',
tfarina 2014/04/18 15:30:37 also, this path is "wrong", you don't need to go u
tfarina 2014/04/18 15:35:17 just 'onc_component' also works, because you are i
mef 2014/04/18 15:38:25 sgtm, I'll do that.
12 ], 13 ],
13 'include_dirs': [ 14 'include_dirs': [
14 '..', 15 '..',
15 ], 16 ],
16 'defines': [ 17 'defines': [
17 'ONC_IMPLEMENTATION', 18 'WIFI_IMPLEMENTATION',
18 ], 19 ],
19 'sources': [ 20 'sources': [
20 'onc/onc_constants.cc', 21 'wifi/wifi_export.h',
21 'onc/onc_constants.h', 22 'wifi/wifi_service.cc',
22 'onc/onc_export.h', 23 'wifi/wifi_service.h',
24 'wifi/fake_wifi_service.cc',
tfarina 2014/04/18 00:46:54 this is including test code in production code.
mef 2014/04/18 14:57:40 Should I move it to //src/chrome/browser/extension
tfarina 2014/04/18 15:28:07 either that or what I have initially thought in do
mef 2014/04/18 15:38:25 Sounds good, I'll do that
23 ], 25 ],
24 }, 26 },
25 ], 27 ],
26 } 28 }
OLDNEW
« no previous file with comments | « components/components.gyp ('k') | components/wifi/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698