components/wifi/OWNERS - Issue 54323003: Base infrastructure for Networking Private API on Windows and Mac.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/wifi/OWNERS

Issue 54323003: Base infrastructure for Networking Private API on Windows and Mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address joi's comments. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 joi@chromium.org	1 joi@chromium.org
	Jói 2013/11/20 16:21:36 You should add yourself and perhaps one or two oth You should add yourself and perhaps one or two other folks who know this code, not me. I'm already a top-level owner for //components and I don't really know the code in //components/wifi especially well. Same comment goes for the per-file OWNERS in //components/OWNERS. mef 2013/11/20 20:33:26 Done. I've explicitly added you because you've rev Show quoted text On 2013/11/20 16:21:36, Jói wrote: > You should add yourself and perhaps one or two other folks who know this code, > not me. > > I'm already a top-level owner for //components and I don't really know the code > in //components/wifi especially well. > > Same comment goes for the per-file OWNERS in //components/OWNERS. Done. I've explicitly added you because you've reviewed the original WiFiService Windows implementation (https://codereview.chromium.org/27722003/). I would add afontan@, who has also reviewed the code, but he doesn't have chromium account. I'm open for suggestions in regards to additional owners.
OLD	NEW