Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 543223002: Version number and download URL updates for Reader plugin on Windows. (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Version number and download URL updates for Reader plugin on Windows. BUG=412047 Committed: https://crrev.com/87d125f0ee8f9900bae161cf26379a45f73538b8 Cr-Commit-Position: refs/heads/master@{#293849}

Patch Set 1 #

Total comments: 4

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M chrome/browser/resources/plugin_metadata/plugins_win.json View 1 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Lei Zhang
6 years, 3 months ago (2014-09-05 21:38:25 UTC) #2
Bernhard Bauer
LGTM with two comments: https://codereview.chromium.org/543223002/diff/1/chrome/browser/resources/plugin_metadata/plugins_win.json File chrome/browser/resources/plugin_metadata/plugins_win.json (right): https://codereview.chromium.org/543223002/diff/1/chrome/browser/resources/plugin_metadata/plugins_win.json#newcode2 chrome/browser/resources/plugin_metadata/plugins_win.json:2: "x-version": 12, Bump the version ...
6 years, 3 months ago (2014-09-08 07:47:46 UTC) #3
Lei Zhang
https://codereview.chromium.org/543223002/diff/1/chrome/browser/resources/plugin_metadata/plugins_win.json File chrome/browser/resources/plugin_metadata/plugins_win.json (right): https://codereview.chromium.org/543223002/diff/1/chrome/browser/resources/plugin_metadata/plugins_win.json#newcode2 chrome/browser/resources/plugin_metadata/plugins_win.json:2: "x-version": 12, On 2014/09/08 07:47:45, Bernhard Bauer wrote: > ...
6 years, 3 months ago (2014-09-08 20:37:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/543223002/20001
6 years, 3 months ago (2014-09-08 20:45:13 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as e9606c5ea2f446fd1e8078efc9790106cda1e80a
6 years, 3 months ago (2014-09-09 04:49:30 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:50:22 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/87d125f0ee8f9900bae161cf26379a45f73538b8
Cr-Commit-Position: refs/heads/master@{#293849}

Powered by Google App Engine
This is Rietveld 408576698