Issue 543203004: Revert "Move some scroll invalidations to the paint invalidation phase"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 543203004: Revert "Move some scroll invalidations to the paint invalidation phase" (Closed)

Created:
6 years, 3 months ago by arv (Not doing code reviews)

Modified:
6 years, 3 months ago

Reviewers:
keishi, Julien - ping for review

CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering, pdr., rune+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Revert "Move some scroll invalidations to the paint invalidation phase" This reverts commit 11871f14944c99fa718abfc12226ddc8d1da71a8. Revert "Auto-rebaseline for r181475" This reverts commit ccabe1281427cc3be9c2708bbdbfaba8ab7bd087. These CLs mayb have broken a LOT of Mac pixel tests. I will watch the bots... TBR=jchaffraix@chromium.org, keishi Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181483

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+110 lines, -48 lines)			Patch
M	LayoutTests/compositing/repaint/fixed-pos-inside-composited-intermediate-layer-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/compositing/repaint/fixed-pos-with-abs-pos-child-scroll-expected.txt	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	LayoutTests/compositing/repaint/fixed-pos-with-composited-child-expected.txt	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	LayoutTests/fast/layers/scroll-descendant-with-cached-cliprects-expected.txt	View	1 chunk	+11 lines, -11 lines	0 comments	Download
M	LayoutTests/fast/repaint/fixed-scroll-simple-expected.txt	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	LayoutTests/platform/linux/fast/layers/scroll-descendant-with-cached-cliprects-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	LayoutTests/platform/mac-lion/fast/layers/scroll-descendant-with-cached-cliprects-expected.png	View	Binary file		0 comments	Download
A +	LayoutTests/platform/mac-lion/fast/layers/scroll-descendant-with-cached-cliprects-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	LayoutTests/platform/mac-mountainlion/fast/layers/scroll-descendant-with-cached-cliprects-expected.png	View	Binary file		0 comments	Download
A +	LayoutTests/platform/mac-mountainlion/fast/layers/scroll-descendant-with-cached-cliprects-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	LayoutTests/platform/mac-retina/fast/layers/scroll-descendant-with-cached-cliprects-expected.png	View	Binary file		0 comments	Download
A +	LayoutTests/platform/mac-retina/fast/layers/scroll-descendant-with-cached-cliprects-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	LayoutTests/platform/mac-snowleopard/fast/layers/scroll-descendant-with-cached-cliprects-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	LayoutTests/platform/mac/fast/layers/scroll-descendant-with-cached-cliprects-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/platform/win-xp/fast/layers/scroll-descendant-with-cached-cliprects-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	LayoutTests/platform/win/fast/layers/scroll-descendant-with-cached-cliprects-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/frame/FrameView.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	Source/core/frame/FrameView.cpp	View	7 chunks	+67 lines, -19 lines	0 comments	Download
M	Source/core/rendering/RenderLayerRepainter.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/rendering/RenderLayerRepainter.cpp	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	Source/platform/scroll/ScrollView.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

arv (Not doing code reviews)

6 years, 3 months ago (2014-09-05 22:07:35 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 181483 (presubmit successful).

Expand Messages | Collapse Messages