Fix the geofencing test to not break if the promises resolve asynchronously.

LayoutTests/geofencing/geofencing-not-implemented.html

Index: LayoutTests/geofencing/geofencing-not-implemented.html
diff --git a/LayoutTests/geofencing/geofencing-not-implemented.html b/LayoutTests/geofencing/geofencing-not-implemented.html
index dc44262e096235ffde2c226e0528894523ecea02..bb4f421b914d7bee2f6616653282d2cf8c7931e9 100644
--- a/LayoutTests/geofencing/geofencing-not-implemented.html
+++ b/LayoutTests/geofencing/geofencing-not-implemented.html
@@ -7,16 +7,41 @@
 <script>
 description("Tests that all geofencing methods always reject.");
 
-function shouldReject(promise)
-{
-    promise.then(
-        function() { testFailed("Promise unexpectedly resolved."); },
-        function() { testPassed("Promise rejected as expected."); });
-}
+var jsTestIsAsync = true;
+
+var tests = [
+    function() {
+        return navigator.geofencing.registerRegion(new CircularGeofencingRegion({latitude: 37.421999, longitude: -122.084015}));
+    },
+    function() {
+        return navigator.geofencing.unregisterRegion("");
+    },
+    function() {
+        return navigator.geofencing.getRegisteredRegions();
+    }
+];
 
-shouldReject(navigator.geofencing.registerRegion(new CircularRegion({latitude: 37.421999, longitude: -122.084015})));
-shouldReject(navigator.geofencing.unregisterRegion(""));
-shouldReject(navigator.geofencing.getRegisteredRegions());
+function nextTest() {

[Peter Beverloo, 2014/09/11 16:32:21]

The nextTest() function (lines 24-43) sounds really generic, but does in fact
contain the expected results. Perhaps:

  (a) Use test harness for this test, explicitly indicating what is expected.
  (b) Rely on the test expectation file (geofencing-not-implemented.txt) to
indicate whether the promises should reject or resolve.

[Marijn Kruisselbrink, 2014/09/11 19:11:06]

I'm now using testharness (and in fact the exact same test code as in the
serviceworker test).

I suppose it might make sense to even split out the tests themselves into a
separate file so both this file and the serviceworker can just include that
file, but then I'm not sure if these tests will stick around anyway. At some
point geofencing will actually be implemented, and I'm not sure what can and
can't be tested in layouttests at that point (the actual implementation of
geofencing will be easiest to test in unittests for the browserprocess code, but
there should still be some kind of test on the blink side as well of course).

+    if (tests.length == 0) {
+        finishJSTest();
+        return;
+    }
+    var test = tests.shift();
+    try {
+        test()
+        .then(function() {
+            testFailed("Promise unexpectedly resolved.");
+            nextTest();
+        }).catch(function(e) {
+            testPassed("Promise rejected as expected.");
+            nextTest();
+        });
+    } catch (e) {
+        testFailed("Unexpected exception.");
+        nextTest();
+    }
+}
+nextTest();
 </script>
 </body>
 </html>