LayoutTests/http/tests/geofencing/service-worker.html - Issue 543203003: Fix the geofencing test to not break if the promises resolve asynchronously.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/geofencing/service-worker.html

Issue 543203003: Fix the geofencing test to not break if the promises resolve asynchronously. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../resources/testharness.js"></script>

	3 <script src="../resources/testharnessreport.js"></script>

	4 <script src="../serviceworker/resources/test-helpers.js"></script>
	Peter Beverloo 2014/09/11 16:32:21 This feels really fragile because we don't have ex This feels really fragile because we don't have explicit dependencies within layout tests. We have plenty of this, so fine to go ahead, but it might be useful to generalize some test harness + * Workers utility scripts.
	5 <script>

	6 var test = async_test('Verify geofencing in a Service Worker');
	Peter Beverloo 2014/09/11 16:32:21 Please clarify the description a bit (verify which Please clarify the description a bit (verify which bit of Geofencing?).
	7 test.step(function() {

	8 var scope = 'resources/blank.html';

	9 service_worker_unregister_and_register(

	10 test, 'resources/worker.js', scope)

	11 .then(function(registration) {

	12 return wait_for_update(test, registration);

	13 })
	Peter Beverloo 2014/09/11 16:32:21 nit: indentation in this block seems to be off. Pl nit: indentation in this block seems to be off. Please always use four characters. You don't need to break lines 9 and 10 (Blink does not have line length limits). Marijn Kruisselbrink 2014/09/11 19:11:06 Since I rewrote this code entirely, this exact iss Show quoted text On 2014/09/11 16:32:21, Peter Beverloo wrote: > nit: indentation in this block seems to be off. Please always use four > characters. You don't need to break lines 9 and 10 (Blink does not have line > length limits). Since I rewrote this code entirely, this exact issue no longer exists, but I'm not entirely sure if the indentation I'm using now is the correct one either. There seem to be plenty of cases in promises using test code where parts of the code are not indented to a multiple of four characters, but maybe those are all wrong...
	14 .then(onRegister)

	15 .catch(unreached_rejection(test));

	16

	17 function onRegister(worker) {

	18 var messageChannel = new MessageChannel();

	19 messageChannel.port1.onmessage = test.step_func(onMessage);

	20 worker.postMessage({port: messageChannel.port2}, [messageChannel.port2]) ;

	21 }

	22

	23 var result = [];

	24 var expected = [

	25 'Rejected',

	26 'Rejected',

	27 'Rejected',

	28 ];

	29

	30 function onMessage(e) {

	31 var message = e.data;

	32 if (message == 'quit') {

	33 assert_array_equals(result, expected, 'Worker should post back expec ted values.');

	34 service_worker_unregister_and_done(test, scope);

	35 } else {

	36 result.push(message);

	37 }

	38 }

	39 });

	40 </script>

OLD	NEW

« LayoutTests/geofencing/geofencing-not-implemented.html ('K') | « LayoutTests/http/tests/geofencing/resources/worker.js ('k') | no next file » | no next file with comments »