Issue 543193002: Make ProcessReaderModule and ProcessReaderThread nested classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 543193002: Make ProcessReaderModule and ProcessReaderThread nested classes (Closed)

Created:
6 years, 3 months ago by Mark Mentovai

Modified:
6 years, 3 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Project:
crashpad

Visibility:
Public.

More Reviews

Description

Make ProcessReaderModule and ProcessReaderThread nested classes. This change is being made in response to the suggestion at https://codereview.chromium.org/539263003/diff/20001/util/mac/mach_o_image_symbol_table_reader.h#newcode45 TEST=util_test ProcessReader.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/3d4eeae86437cb61935de6e70a9a24ee2909d986

Patch Set 2 : Address review feedback #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -70 lines)			Patch
M	util/mac/process_reader.h	View	1	3 chunks	+53 lines, -52 lines	0 comments	Download
M	util/mac/process_reader.cc	View		8 chunks	+9 lines, -9 lines	0 comments	Download
M	util/mac/process_reader_test.cc	View		9 chunks	+10 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Robert Sesek

LGTM https://codereview.chromium.org/543193002/diff/1/util/mac/process_reader.h File util/mac/process_reader.h (right): https://codereview.chromium.org/543193002/diff/1/util/mac/process_reader.h#newcode42 util/mac/process_reader.h:42: #if defined(ARCH_CPU_X86_FAMILY) Should #if's be indented?

6 years, 3 months ago (2014-09-05 20:28:08 UTC) #3

Mark Mentovai

6 years, 3 months ago (2014-09-05 20:35:20 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 3d4eeae (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 543193002: Make ProcessReaderModule and ProcessReaderThread nested classes (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address review feedback #

Messages