Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 543163002: ChromeOS: GetProfileByUser should not be called from Preferences::Init. (Closed)

Created:
6 years, 3 months ago by Alexander Alekseev
Modified:
6 years, 3 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ChromeOS: GetProfileByUser should not be called from Preferences::Init. This fixes crash, because GetProfileByUser is now returning NULL there. BUG=411216, 410617 TEST=manual Committed: https://crrev.com/829e2bf7e125704e05701017891d2ffdfc3755fd Cr-Commit-Position: refs/heads/master@{#293614}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/chromeos/preferences.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Alexander Alekseev
Please review.
6 years, 3 months ago (2014-09-05 18:50:17 UTC) #2
xiyuan
lgtm
6 years, 3 months ago (2014-09-05 19:13:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alemate@chromium.org/543163002/1
6 years, 3 months ago (2014-09-05 19:14:58 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/5859)
6 years, 3 months ago (2014-09-05 22:03:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alemate@chromium.org/543163002/1
6 years, 3 months ago (2014-09-06 07:11:29 UTC) #11
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 10:32:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alemate@chromium.org/543163002/1
6 years, 3 months ago (2014-09-06 13:24:21 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1) as b8c5d8c896933a82ba879e8396cc1c4cdbf5af67
6 years, 3 months ago (2014-09-06 13:25:33 UTC) #16
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:42:30 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/829e2bf7e125704e05701017891d2ffdfc3755fd
Cr-Commit-Position: refs/heads/master@{#293614}

Powered by Google App Engine
This is Rietveld 408576698