Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Issue 543153002: More compiler whack-a-mole. (Closed)

Created:
6 years, 3 months ago by Nico
Modified:
6 years, 3 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/c006ff2a6f7547f36f42b9958a15b73df03c7c2b Cr-Commit-Position: refs/heads/master@{#293580}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -28 lines) Patch
M sandbox/win/sandbox_poc/pocdll/registry.cc View 3 chunks +14 lines, -28 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
This time I even checked that this builds with both cl and clang at the ...
6 years, 3 months ago (2014-09-05 18:43:16 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm
6 years, 3 months ago (2014-09-05 20:05:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/543153002/1
6 years, 3 months ago (2014-09-05 20:12:10 UTC) #5
Nico
Committed patchset #1 (id:1) to pending queue manually as 6f949d4 (presubmit successful).
6 years, 3 months ago (2014-09-05 21:16:49 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:41:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c006ff2a6f7547f36f42b9958a15b73df03c7c2b
Cr-Commit-Position: refs/heads/master@{#293580}

Powered by Google App Engine
This is Rietveld 408576698