Close AppWindow to perform clean shutdown

extensions/shell/browser/shell_desktop_controller.h

Index: extensions/shell/browser/shell_desktop_controller.h
diff --git a/extensions/shell/browser/shell_desktop_controller.h b/extensions/shell/browser/shell_desktop_controller.h
index b05da74a64023fdc0e86467faca7e0a1f436ea7d..325f3cc39bc840e0ea3bcfcb16e2939122746f95 100644
--- a/extensions/shell/browser/shell_desktop_controller.h
+++ b/extensions/shell/browser/shell_desktop_controller.h
@@ -68,8 +68,11 @@ class ShellDesktopController : public DesktopController,
 
   // DesktopController:
   virtual aura::WindowTreeHost* GetHost() OVERRIDE;
-  virtual ShellAppWindow* CreateAppWindow(content::BrowserContext* context,
-                                          const Extension* extension) OVERRIDE;
+  virtual ShellAppWindow* CreateShellAppWindow(
+      content::BrowserContext* context,
+      const Extension* extension) OVERRIDE;
+  virtual AppWindow* CreateAppWindow(content::BrowserContext* context,
+                                     const Extension* extension) OVERRIDE;
   virtual void AddAppWindow(aura::Window* window) OVERRIDE;
   virtual void CloseAppWindows() OVERRIDE;
 
@@ -132,7 +135,8 @@ class ShellDesktopController : public DesktopController,
 #endif
 
   // The desktop supports a single app window.
-  scoped_ptr<ShellAppWindow> app_window_;
+  scoped_ptr<ShellAppWindow> shell_app_window_;
+  AppWindow* app_window_;

[James Cook, 2014/09/08 18:14:31]

nit: Maybe comment that this is not owned?

[James Cook, 2014/09/09 15:32:23]

Or comment that the memory is cleaned up by the NativeAppWindow?

It's just very confusing that the DesktopController "owns" a ShellAppWindow or
an AppWindow, but is responsible for deleting the ShellAppWindow and is not
(directly) responsible for deleting the AppWindow.

[hashimoto, 2014/09/09 16:32:44]

Added comments here and in ShellDesktopController::CloseAppWindows().

 
   DISALLOW_COPY_AND_ASSIGN(ShellDesktopController);
 };