Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 543123003: Don't squash fixed-position elements into another fixed-position element that has a clip. (Closed)

Created:
6 years, 3 months ago by chrishtr
Modified:
6 years, 3 months ago
CC:
abarth-chromium, blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Don't squash fixed-position elements into another fixed-position element that has an overflow clip. Previously it checked for clip but not overflow clip. BUG=409680 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181495

Patch Set 1 #

Patch Set 2 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -9 lines) Patch
A LayoutTests/compositing/squashing/no-squashing-into-fixed-position-that-clips.html View 1 chunk +45 lines, -0 lines 0 comments Download
A + LayoutTests/compositing/squashing/no-squashing-into-fixed-position-that-clips-expected.txt View 1 chunk +9 lines, -9 lines 0 comments Download
M Source/core/rendering/compositing/CompositingInputsUpdater.cpp View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
chrishtr
6 years, 3 months ago (2014-09-05 18:14:00 UTC) #2
abarth-chromium
lgtm
6 years, 3 months ago (2014-09-05 20:09:32 UTC) #3
chrishtr
Updated to narrow the logic to just position: fixed within position: fixed. Otherwise, overflow should ...
6 years, 3 months ago (2014-09-05 20:54:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/543123003/20001
6 years, 3 months ago (2014-09-05 20:54:29 UTC) #6
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 02:55:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/543123003/20001
6 years, 3 months ago (2014-09-06 03:01:19 UTC) #10
chrishtr
lgtm
6 years, 3 months ago (2014-09-06 03:50:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/543123003/20001
6 years, 3 months ago (2014-09-06 03:50:40 UTC) #13
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 11:09:02 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/543123003/20001
6 years, 3 months ago (2014-09-06 15:54:05 UTC) #17
commit-bot: I haz the power
6 years, 3 months ago (2014-09-06 15:55:59 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 181495

Powered by Google App Engine
This is Rietveld 408576698