Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 543093003: ReReland ServiceWorkerCacheStorage::Keys function (Closed)

Created:
6 years, 3 months ago by jkarlin
Modified:
6 years, 3 months ago
Reviewers:
michaeln, horo
CC:
chromium-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ReReland ServiceWorkerCacheStorage::Keys function Suppression (error hash=#E226F7559AD360E7#): For more info on using suppressions see http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/memory-sheriff#TOC-Suppressing-memory-reports { <insert_a_suppression_name_here> Memcheck:Leak fun:_Znw* fun:_ZN4base8internal20PostTaskAndReplyImpl16PostTaskAndReplyERKN15tracked_objects8LocationERKNS_8CallbackIFvvEEESA_ fun:_ZN4base10TaskRunner16PostTaskAndReplyERKN15tracked_objects8LocationERKNS_8CallbackIFvvEEES9_ fun:_ZN10disk_cache15SimpleEntryImpl13CloseInternalEv fun:_ZN10disk_cache15SimpleEntryImpl24RunNextOperationIfNeededEv fun:_ZN10disk_cache15SimpleEntryImpl21DoomOperationCompleteERKN4base8CallbackIFviEEENS0_5StateEi } Original CL: https://codereview.chromium.org/477973002/ Reland: https://codereview.chromium.org/528233003/ The SimpleCache backend wasn't given a chance to finish up a close operation before the IO messageloop closed at the end of functions. The tests now run the loop in TearDown. The original patch is PatchSet1 and the fix is PatchSet3. BUG=392621 Committed: https://crrev.com/bbfe6ce49b8e99b190085dffbf446b474c5f07ff Cr-Commit-Position: refs/heads/master@{#294090}

Patch Set 1 : Reverted Code #

Patch Set 2 : Rebase #

Patch Set 3 : TearDown #

Unified diffs Side-by-side diffs Delta from patch set Stats (+344 lines, -58 lines) Patch
M content/browser/service_worker/service_worker_cache.h View 4 chunks +23 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_cache.cc View 11 chunks +212 lines, -37 lines 0 comments Download
M content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_cache_unittest.cc View 1 2 7 chunks +103 lines, -21 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
jkarlin
michaeln@chromium.org: Please review changes in all horo@chromium.org: Please review changes in all Thanks so much!
6 years, 3 months ago (2014-09-09 21:15:25 UTC) #7
michaeln
lgtm
6 years, 3 months ago (2014-09-09 21:53:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jkarlin@chromium.org/543093003/140001
6 years, 3 months ago (2014-09-09 22:19:36 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/10686)
6 years, 3 months ago (2014-09-10 00:58:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jkarlin@chromium.org/543093003/140001
6 years, 3 months ago (2014-09-10 02:10:10 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:140001) as 6352acb3779bdb6ea6ba5e46c2a3e8067489c037
6 years, 3 months ago (2014-09-10 03:28:21 UTC) #15
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/bbfe6ce49b8e99b190085dffbf446b474c5f07ff Cr-Commit-Position: refs/heads/master@{#294090}
6 years, 3 months ago (2014-09-10 03:58:44 UTC) #16
jkarlin
On 2014/09/10 03:58:44, I haz the power (commit-bot) wrote: > Patchset 3 (id:??) landed as ...
6 years, 3 months ago (2014-09-10 09:31:31 UTC) #17
jkarlin
6 years, 3 months ago (2014-09-10 09:32:56 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:140001) has been created in
https://codereview.chromium.org/562613002/ by jkarlin@chromium.org.

The reason for reverting is: Linux Valgrind now passes but ChromeOS Valgrind
doesn't.  Looks like I need to do more on TearDown..

Powered by Google App Engine
This is Rietveld 408576698