Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 543093002: Fix focus on popup GTK dialogs (Closed)

Created:
6 years, 3 months ago by Arjan van Leeuwen
Modified:
6 years, 3 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix focus on popup GTK dialogs Previously we didn't have a call to gtk_window_present(), which would mean that the widgets would become visible, but the necessary actions to focus weren't always taken. This resulted in the active window not being correct after opening the file or print dialogs. BUG=399514 Committed: https://crrev.com/b7954eebe6fe06dd1e585c83efa7a20e7be0a2ac Cr-Commit-Position: refs/heads/master@{#293691}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M chrome/browser/ui/libgtk2ui/print_dialog_gtk2.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Arjan van Leeuwen
6 years, 3 months ago (2014-09-05 13:29:16 UTC) #2
Elliot Glaysher
lgtm
6 years, 3 months ago (2014-09-05 17:21:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arjanl@opera.com/543093002/1
6 years, 3 months ago (2014-09-08 07:55:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as d4b45f0ede6a83aa0ba71fe42cc9316b5c87f79a
6 years, 3 months ago (2014-09-08 08:51:50 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:45:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b7954eebe6fe06dd1e585c83efa7a20e7be0a2ac
Cr-Commit-Position: refs/heads/master@{#293691}

Powered by Google App Engine
This is Rietveld 408576698