Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: net/url_request/url_fetcher.h

Issue 543073003: Improve URLFetcher documentation for retry on 5XX settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_fetcher.h
diff --git a/net/url_request/url_fetcher.h b/net/url_request/url_fetcher.h
index 415d7e525cdb1daf34aebe69b4f0004568fb3bc2..1b379c4c23abef5ef5881e5a7b6f71ee7cfd2946 100644
--- a/net/url_request/url_fetcher.h
+++ b/net/url_request/url_fetcher.h
@@ -215,11 +215,15 @@ class NET_EXPORT URLFetcher {
// server response code.
virtual void SetStopOnRedirect(bool stop_on_redirect) = 0;
- // If |retry| is false, 5xx responses will be propagated to the observer,
- // if it is true URLFetcher will automatically re-execute the request,
- // after backoff_delay() elapses. URLFetcher has it set to true by default.
+ // If |retry| is false, 5xx responses will be propagated to the observer. If
+ // it is true URLFetcher will automatically re-execute the request, after
+ // backoff_delay() elapses, up to the maximum number of retries allowed by
+ // SetMaxRetriesOn5xx. Defaults to true.
virtual void SetAutomaticallyRetryOn5xx(bool retry) = 0;
+ // |max_retries| is the maximum number of times URLFetcher will retry a
+ // request that receives a 5XX response. Depends on
+ // SetAutomaticallyRetryOn5xx. Defaults to 0.
virtual void SetMaxRetriesOn5xx(int max_retries) = 0;
virtual int GetMaxRetriesOn5xx() const = 0;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698