Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 543073003: Improve URLFetcher documentation for retry on 5XX settings. (Closed)

Created:
6 years, 3 months ago by maniscalco
Modified:
6 years, 3 months ago
Reviewers:
Ryan Sleevi, mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Improve URLFetcher documentation for retry on 5XX settings. BUG= Committed: https://crrev.com/bd54da791fd09ab07b2480e328da4430ff792e5e Cr-Commit-Position: refs/heads/master@{#293594}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M net/url_request/url_fetcher.h View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
maniscalco
Hi Ryan, would you please review this change?
6 years, 3 months ago (2014-09-05 17:05:19 UTC) #3
Ryan Sleevi
Redirect to mattm, but this looks right.
6 years, 3 months ago (2014-09-05 17:09:56 UTC) #5
mattm
lgtm
6 years, 3 months ago (2014-09-05 22:09:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maniscalco@chromium.org/543073003/20001
6 years, 3 months ago (2014-09-05 22:56:02 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001) as dbbb27a20d3773b19e50405b45d02e407eeff302
6 years, 3 months ago (2014-09-05 23:40:13 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:41:56 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd54da791fd09ab07b2480e328da4430ff792e5e
Cr-Commit-Position: refs/heads/master@{#293594}

Powered by Google App Engine
This is Rietveld 408576698