Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 543073002: Don't paint text outside display area (Closed)

Created:
6 years, 3 months ago by Arjan van Leeuwen
Modified:
6 years, 3 months ago
CC:
chromium-reviews, Alexei Svitkine (slow), ckocagil
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Don't paint text outside display area When rendering text, we don't have to render glyphs that fall outside of the display area. This change stops processing glyps when we're outside the display area, and stops processing further style ranges if those are outside the display area. Note that the equivalent functionality is already in place for Windows text rendering. This fixes an issue where text rendering would become very slow when rendering big strings. BUG=413540 Committed: https://crrev.com/88328875c41317c728a20b78308218c176a6ee72 Cr-Commit-Position: refs/heads/master@{#295023}

Patch Set 1 #

Total comments: 5

Patch Set 2 : Add comments and don't change glyph_text_index. #

Total comments: 1

Patch Set 3 : Increase indentation on comment (from review). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M ui/gfx/render_text_pango.cc View 1 2 3 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (5 generated)
Arjan van Leeuwen
This fixes a performance issue we had with very long URLs in the address bar. ...
6 years, 3 months ago (2014-09-05 13:15:14 UTC) #2
msw
This seems fine other than the |glyph_text_index| change. It'd be even nicer if we could ...
6 years, 3 months ago (2014-09-05 20:15:32 UTC) #3
Arjan van Leeuwen
https://codereview.chromium.org/543073002/diff/1/ui/gfx/render_text_pango.cc File ui/gfx/render_text_pango.cc (right): https://codereview.chromium.org/543073002/diff/1/ui/gfx/render_text_pango.cc#newcode454 ui/gfx/render_text_pango.cc:454: SkScalarTruncToInt(x) >= display_rect().right()) On 2014/09/05 20:15:32, msw wrote: > ...
6 years, 3 months ago (2014-09-08 09:20:11 UTC) #4
msw
https://codereview.chromium.org/543073002/diff/1/ui/gfx/render_text_pango.cc File ui/gfx/render_text_pango.cc (right): https://codereview.chromium.org/543073002/diff/1/ui/gfx/render_text_pango.cc#newcode413 ui/gfx/render_text_pango.cc:413: // Don't do anything if we're outside the display ...
6 years, 3 months ago (2014-09-08 19:10:30 UTC) #5
Arjan van Leeuwen
https://codereview.chromium.org/543073002/diff/1/ui/gfx/render_text_pango.cc File ui/gfx/render_text_pango.cc (right): https://codereview.chromium.org/543073002/diff/1/ui/gfx/render_text_pango.cc#newcode454 ui/gfx/render_text_pango.cc:454: SkScalarTruncToInt(x) >= display_rect().right()) On 2014/09/08 19:10:30, msw wrote: > ...
6 years, 3 months ago (2014-09-09 07:03:59 UTC) #6
msw
Great, LGTM, thanks!
6 years, 3 months ago (2014-09-09 18:20:22 UTC) #7
Alexei Svitkine (slow)
Deferring to msw's review % my nit below. Is there a crbug.com on file for ...
6 years, 3 months ago (2014-09-09 19:26:30 UTC) #8
Arjan van Leeuwen
On 2014/09/09 19:26:30, Alexei Svitkine wrote: > Deferring to msw's review % my nit below. ...
6 years, 3 months ago (2014-09-10 06:36:10 UTC) #9
Arjan van Leeuwen
6 years, 3 months ago (2014-09-10 06:36:17 UTC) #10
Alexei Svitkine (slow)
Could you file one then and then associate with the CL? On Wed, Sep 10, ...
6 years, 3 months ago (2014-09-10 13:43:44 UTC) #11
Arjan van Leeuwen
On 2014/09/10 13:43:44, Alexei Svitkine wrote: > Could you file one then and then associate ...
6 years, 3 months ago (2014-09-12 06:28:29 UTC) #12
Alexei Svitkine (slow)
Thanks, LGTM!
6 years, 3 months ago (2014-09-12 15:32:33 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/543073002/40001
6 years, 3 months ago (2014-09-13 14:36:29 UTC) #16
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-13 16:36:54 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/543073002/40001
6 years, 3 months ago (2014-09-16 06:34:54 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 29d646dd9a03638be85ece44929d7f5fde12d4f8
6 years, 3 months ago (2014-09-16 07:15:24 UTC) #21
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 07:16:43 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/88328875c41317c728a20b78308218c176a6ee72
Cr-Commit-Position: refs/heads/master@{#295023}

Powered by Google App Engine
This is Rietveld 408576698