Remove duplicated rule from web.gyp and enable chromium_code for all targets.

Remove duplicated rule from web.gyp.

BUG=312287
TBR=dglazkov

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161091

[lgombos, 2013-10-31 16:03:52]

Setting chromium_code=1 is unnecessary duplication in web.gyp as this rule
should be global for blink.

[Nico, 2013-10-31 16:15:21]

I see how this CL does "Remove duplicated rule from web.gyp". I don't see the
"enable chromium_code for all targets." bit.

[Nico, 2013-10-31 16:15:36]

(I mean, it's still disabled on windows or with clang)

[lgombos, 2013-10-31 18:50:10]

On 2013/10/31 16:15:21, Nico wrote:
> I see how this CL does "Remove duplicated rule from web.gyp". I don't see the
> "enable chromium_code for all targets." bit.

Target here means gyp target (e.g. web:gyp:webkit_test_support) and not
configuration target (e.g. gcc vs clang). Sorry for the confusion.

[Nico, 2013-10-31 18:54:01]

On Thu, Oct 31, 2013 at 11:50 AM, <l.gombos@samsung.com> wrote:

> On 2013/10/31 16:15:21, Nico wrote:
>
>> I see how this CL does "Remove duplicated rule from web.gyp". I don't see
>> the
>> "enable chromium_code for all targets." bit.
>>
>
> Target here means gyp target (e.g. web:gyp:webkit_test_support) and not
> configuration target (e.g. gcc vs clang). Sorry for the confusion.
>

I see. Maybe just remove the second part from the CL description then.
Either way, lgtm, thanks!


>
>
>
https://codereview.chromium.**org/54303004/<https://codereview.chromium.org/5...
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2013-10-31 19:13:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/l.gombos@samsung.com/54303004/1

[commit-bot: I haz the power, 2013-10-31 19:28:22]

Retried try job too often on blink_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

[commit-bot: I haz the power, 2013-10-31 19:29:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/l.gombos@samsung.com/54303004/1

[commit-bot: I haz the power, 2013-10-31 20:26:02]

Change committed as 161091