Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/x87/code-stubs-x87.h

Issue 543013002: X87: Clean up code stubs and ensure distinct major keys. (Closed) Base URL: https://github.com/v8/v8.git@bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/x87/handler-compiler-x87.cc ('k') | src/x87/code-stubs-x87.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_X87_CODE_STUBS_X87_H_ 5 #ifndef V8_X87_CODE_STUBS_X87_H_
6 #define V8_X87_CODE_STUBS_X87_H_ 6 #define V8_X87_CODE_STUBS_X87_H_
7 7
8 #include "src/code-stubs.h" 8 #include "src/code-stubs.h"
9 9
10 namespace v8 { 10 namespace v8 {
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 static const int kTotalProbes = 20; 107 static const int kTotalProbes = 20;
108 108
109 static const int kCapacityOffset = 109 static const int kCapacityOffset =
110 NameDictionary::kHeaderSize + 110 NameDictionary::kHeaderSize +
111 NameDictionary::kCapacityIndex * kPointerSize; 111 NameDictionary::kCapacityIndex * kPointerSize;
112 112
113 static const int kElementsStartOffset = 113 static const int kElementsStartOffset =
114 NameDictionary::kHeaderSize + 114 NameDictionary::kHeaderSize +
115 NameDictionary::kElementsStartIndex * kPointerSize; 115 NameDictionary::kElementsStartIndex * kPointerSize;
116 116
117 Major MajorKey() const { return NameDictionaryLookup; } 117 virtual inline Major MajorKey() const FINAL OVERRIDE;
118 118
119 Register dictionary() const { 119 Register dictionary() const {
120 return Register::from_code(DictionaryBits::decode(minor_key_)); 120 return Register::from_code(DictionaryBits::decode(minor_key_));
121 } 121 }
122 122
123 Register result() const { 123 Register result() const {
124 return Register::from_code(ResultBits::decode(minor_key_)); 124 return Register::from_code(ResultBits::decode(minor_key_));
125 } 125 }
126 126
127 Register index() const { 127 Register index() const {
(...skipping 203 matching lines...) Expand 10 before | Expand all | Expand 10 after
331 return no_reg; 331 return no_reg;
332 } 332 }
333 friend class RecordWriteStub; 333 friend class RecordWriteStub;
334 }; 334 };
335 335
336 enum OnNoNeedToInformIncrementalMarker { 336 enum OnNoNeedToInformIncrementalMarker {
337 kReturnOnNoNeedToInformIncrementalMarker, 337 kReturnOnNoNeedToInformIncrementalMarker,
338 kUpdateRememberedSetOnNoNeedToInformIncrementalMarker 338 kUpdateRememberedSetOnNoNeedToInformIncrementalMarker
339 }; 339 };
340 340
341 Major MajorKey() const { return RecordWrite; } 341 virtual inline Major MajorKey() const FINAL OVERRIDE;
342 342
343 void Generate(MacroAssembler* masm); 343 void Generate(MacroAssembler* masm);
344 void GenerateIncremental(MacroAssembler* masm, Mode mode); 344 void GenerateIncremental(MacroAssembler* masm, Mode mode);
345 void CheckNeedsToInformIncrementalMarker( 345 void CheckNeedsToInformIncrementalMarker(
346 MacroAssembler* masm, 346 MacroAssembler* masm,
347 OnNoNeedToInformIncrementalMarker on_no_need, 347 OnNoNeedToInformIncrementalMarker on_no_need,
348 Mode mode); 348 Mode mode);
349 void InformIncrementalMarker(MacroAssembler* masm); 349 void InformIncrementalMarker(MacroAssembler* masm);
350 350
351 void Activate(Code* code) { 351 void Activate(Code* code) {
(...skipping 23 matching lines...) Expand all
375 375
376 RegisterAllocation regs_; 376 RegisterAllocation regs_;
377 377
378 DISALLOW_COPY_AND_ASSIGN(RecordWriteStub); 378 DISALLOW_COPY_AND_ASSIGN(RecordWriteStub);
379 }; 379 };
380 380
381 381
382 } } // namespace v8::internal 382 } } // namespace v8::internal
383 383
384 #endif // V8_X87_CODE_STUBS_X87_H_ 384 #endif // V8_X87_CODE_STUBS_X87_H_
OLDNEW
« no previous file with comments | « src/ic/x87/handler-compiler-x87.cc ('k') | src/x87/code-stubs-x87.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698