Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 543003002: Fix sbox_validation_tests for Server 2012R2 (Closed)

Created:
6 years, 3 months ago by drbasic
Modified:
6 years, 3 months ago
CC:
chromium-reviews, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix sbox_validation_tests for Server 2012R2 Windows Server 2012 returns code 1285L instead of ERROR_ACCESS_DENIED. So sbox_validation_tests fails on Windows Server 2012 R2. R=cpu@chromium.org BUG=411859 Committed: https://crrev.com/a4ee4779134fa1a1c2ae3d1256765813a2ffe4f8 Cr-Commit-Position: refs/heads/master@{#294335}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M sandbox/win/tests/validation_tests/commands.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
drbasic
6 years, 3 months ago (2014-09-05 05:13:27 UTC) #1
cpu_(ooo_6.6-7.5)
returns ERROR_DELAY_LOAD_FAILED ? That is quite unexpected for SetSecurityInfo(). Let me check what server OS ...
6 years, 3 months ago (2014-09-05 20:15:03 UTC) #3
cpu_(ooo_6.6-7.5)
also please create a bug at crbug.com and put it in the BUG= field of ...
6 years, 3 months ago (2014-09-05 20:16:01 UTC) #4
cpu_(ooo_6.6-7.5)
actually, the error might not be as far fetched. lgtm
6 years, 3 months ago (2014-09-10 00:42:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/543003002/1
6 years, 3 months ago (2014-09-11 03:28:25 UTC) #7
drbasic
On 2014/09/10 00:42:11, cpu wrote: > actually, the error might not be as far fetched. ...
6 years, 3 months ago (2014-09-11 03:31:04 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as 2ef6f991dd90c5f08e0039b459ccedeef80e5196
6 years, 3 months ago (2014-09-11 06:04:15 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 06:07:02 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4ee4779134fa1a1c2ae3d1256765813a2ffe4f8
Cr-Commit-Position: refs/heads/master@{#294335}

Powered by Google App Engine
This is Rietveld 408576698