Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 542993002: Add missing dependency (Closed)

Created:
6 years, 3 months ago by Mark Mentovai
Modified:
6 years, 3 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Add missing dependency on util_test_multiprocess_exec_test_child to util_test. R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/2f425e744bf7afb7af2a9ecad77c0df5b4c7fd8a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M util/util.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
This executable is temporary, but as long as it’s here, the dependency should be specified ...
6 years, 3 months ago (2014-09-05 04:38:50 UTC) #2
Robert Sesek
LGTM
6 years, 3 months ago (2014-09-05 16:35:06 UTC) #3
Mark Mentovai
6 years, 3 months ago (2014-09-05 16:40:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 2f425e7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698