Issue 542973002: Fix problems in r293393.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 542973002: Fix problems in r293393. (Closed)

Created:
6 years, 3 months ago by Nico

Modified:
6 years, 3 months ago

Reviewers:
scottmg

CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix problems in r293393. TBR=scottmg@chromium.org Committed: https://crrev.com/54d38dc5ade53006ab29f635cdacfb56620b9f69 Cr-Commit-Position: refs/heads/master@{#293440}

Patch Set 2 : . #

Total comments: 1

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -12 lines)			Patch
	M	chrome/installer/gcapi/gcapi_test.cc	View		2 chunks	+2 lines, -2 lines	1 comment	Download
	M	cloud_print/service/service.gyp	View	1	2 chunks	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nico

Committed patchset #2 (id:10003) manually as 54d38dc (presubmit successful).

6 years, 3 months ago (2014-09-05 04:48:09 UTC) #2

scottmg

lgtm https://codereview.chromium.org/542973002/diff/10003/chrome/installer/gcapi/gcapi_test.cc File chrome/installer/gcapi/gcapi_test.cc (right): https://codereview.chromium.org/542973002/diff/10003/chrome/installer/gcapi/gcapi_test.cc#newcode28 chrome/installer/gcapi/gcapi_test.cc:28: printf("Static call returned result as %d and reason ...

6 years, 3 months ago (2014-09-05 17:09:40 UTC) #3

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:36:50 UTC) #4

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/54d38dc5ade53006ab29f635cdacfb56620b9f69
Cr-Commit-Position: refs/heads/master@{#293440}

Expand Messages | Collapse Messages

Issue 542973002: Fix problems in r293393. (Closed)

Description

Patch Set 1 #

Patch Set 2 : . #

Messages