Issue 54293008: Set runtime type on list and map literals.

Issue 54293008: Set runtime type on list and map literals. (Closed)

Created:
7 years, 1 month ago by karlklose

Modified:
7 years, 1 month ago

Reviewers:
Johnni Winther, kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Set runtime type on list and map literals. R=johnniwinther@google.com BUG=6827, 12889 Committed: https://code.google.com/p/dart/source/detail?r=29747

Patch Set 2 : Address comments. #

Patch Set 3 : Add test for map literals. #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -11 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	1	4 chunks	+14 lines, -0 lines	0 comments	Download
M	tests/corelib/corelib.status	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download
M	tests/language/language_dart2js.status	View		1 chunk	+0 lines, -1 line	0 comments	Download
A +	tests/language/map_literal12_test.dart	View	1 2	1 chunk	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

kasperl

https://codereview.chromium.org/54293008/diff/1/sdk/lib/_internal/compiler/implementation/ssa/builder.dart File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right): https://codereview.chromium.org/54293008/diff/1/sdk/lib/_internal/compiler/implementation/ssa/builder.dart#newcode4513 sdk/lib/_internal/compiler/implementation/ssa/builder.dart:4513: print(arguments); Get rid of the printing. https://codereview.chromium.org/54293008/diff/1/tests/corelib/corelib.status File tests/corelib/corelib.status ...

7 years, 1 month ago (2013-11-01 10:30:57 UTC) #2

karlklose

https://codereview.chromium.org/54293008/diff/1/sdk/lib/_internal/compiler/implementation/ssa/builder.dart File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right): https://codereview.chromium.org/54293008/diff/1/sdk/lib/_internal/compiler/implementation/ssa/builder.dart#newcode4513 sdk/lib/_internal/compiler/implementation/ssa/builder.dart:4513: print(arguments); On 2013/11/01 10:30:57, kasperl wrote: > Get rid ...

7 years, 1 month ago (2013-11-01 10:35:01 UTC) #3

karlklose

7 years, 1 month ago (2013-11-01 14:19:12 UTC) #8

Message was sent while issue was closed.

Committed patchset #3 manually as r29747 (presubmit successful).

Expand Messages | Collapse Messages