Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 54293006: Add additional information to FAIL lines for animation interpolation tests (Closed)

Created:
7 years, 1 month ago by Steve Block
Modified:
7 years, 1 month ago
CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), dstockwell, Timothy Loh, darktears, dino_apple.com, Eric Willigers
Visibility:
Public.

Description

Add additional information to FAIL lines for animation interpolation tests This change adds to the FAIL line the parsed value of the expected style, which can help with debugging. For example ... FAIL: border-image-width from [0] to [20] was [0] at -0.3, expected [0] becomes ... FAIL: border-image-width from [0] to [20] was [0] at -0.3, expected [0] (parsed as [0px]) R=dstockwell@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161327

Patch Set 1 #

Patch Set 2 : Fix file URLs #

Patch Set 3 : Rebased #

Patch Set 4 : Fix rebase #

Patch Set 5 : Fix win expected result #

Patch Set 6 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+270 lines, -269 lines) Patch
M LayoutTests/animations/interpolation/background-image-interpolation-expected.txt View 1 2 chunks +23 lines, -23 lines 0 comments Download
M LayoutTests/animations/interpolation/background-position-interpolation-expected.txt View 1 2 1 chunk +11 lines, -11 lines 0 comments Download
M LayoutTests/animations/interpolation/background-size-interpolation-expected.txt View 1 chunk +19 lines, -19 lines 0 comments Download
M LayoutTests/animations/interpolation/border-image-source-interpolation-expected.txt View 1 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/animations/interpolation/box-shadow-interpolation-expected.txt View 1 chunk +9 lines, -9 lines 0 comments Download
M LayoutTests/animations/interpolation/clip-interpolation-expected.txt View 1 chunk +24 lines, -24 lines 0 comments Download
M LayoutTests/animations/interpolation/filter-interpolation-expected.txt View 1 2 chunks +8 lines, -8 lines 0 comments Download
M LayoutTests/animations/interpolation/flex-interpolation-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/animations/interpolation/line-height-interpolation-expected.txt View 1 2 3 4 chunks +9 lines, -9 lines 0 comments Download
M LayoutTests/animations/interpolation/list-style-image-interpolation-expected.txt View 1 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/animations/interpolation/max-height-interpolation-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/animations/interpolation/max-width-interpolation-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/animations/interpolation/min-height-interpolation-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/animations/interpolation/min-width-interpolation-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/animations/interpolation/resources/interpolation-test.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/svg-fill-interpolation-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/animations/interpolation/svg-stroke-dasharray-interpolation-expected.txt View 4 chunks +31 lines, -31 lines 0 comments Download
M LayoutTests/animations/interpolation/svg-stroke-interpolation-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/animations/interpolation/text-decoration-color-interpolation-expected.txt View 1 chunk +7 lines, -7 lines 0 comments Download
M LayoutTests/animations/interpolation/webkit-background-size-interpolation-expected.txt View 1 chunk +19 lines, -19 lines 0 comments Download
M LayoutTests/animations/interpolation/webkit-column-gap-interpolation-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/animations/interpolation/webkit-column-width-interpolation-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/animations/interpolation/webkit-mask-box-image-source-interpolation-expected.txt View 1 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/animations/interpolation/webkit-mask-image-interpolation-expected.txt View 1 2 chunks +23 lines, -23 lines 0 comments Download
M LayoutTests/animations/interpolation/webkit-mask-position-interpolation-expected.txt View 1 2 1 chunk +11 lines, -11 lines 0 comments Download
M LayoutTests/animations/interpolation/webkit-mask-size-interpolation-expected.txt View 1 chunk +13 lines, -13 lines 0 comments Download
M LayoutTests/animations/interpolation/zoom-iterpolation-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/animations/interpolation/line-height-interpolation-expected.txt View 1 2 4 chunks +9 lines, -9 lines 0 comments Download
M LayoutTests/platform/win/animations/interpolation/line-height-interpolation-expected.txt View 1 2 3 4 4 chunks +9 lines, -9 lines 0 comments Download
M LayoutTests/virtual/web-animations-css/animations/interpolation/box-shadow-interpolation-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M LayoutTests/virtual/web-animations-css/animations/interpolation/filter-interpolation-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Steve Block
7 years, 1 month ago (2013-10-31 23:24:37 UTC) #1
alancutter (OOO until 2018)
lgtm I would even consider going as far as dropping the handwritten version of the ...
7 years, 1 month ago (2013-11-04 00:05:51 UTC) #2
Steve Block
On 2013/11/04 00:05:51, alancutter wrote: > lgtm > > I would even consider going as ...
7 years, 1 month ago (2013-11-04 00:12:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/steveblock@chromium.org/54293006/130001
7 years, 1 month ago (2013-11-05 04:09:57 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=11084
7 years, 1 month ago (2013-11-05 06:06:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/steveblock@chromium.org/54293006/130001
7 years, 1 month ago (2013-11-05 06:10:28 UTC) #6
commit-bot: I haz the power
Failed to trigger a try job on linux_blink HTTP Error 400: Bad Request
7 years, 1 month ago (2013-11-05 06:36:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/steveblock@chromium.org/54293006/360001
7 years, 1 month ago (2013-11-05 06:36:47 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=15508
7 years, 1 month ago (2013-11-05 08:51:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/steveblock@chromium.org/54293006/530001
7 years, 1 month ago (2013-11-05 09:33:21 UTC) #10
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 12:29:30 UTC) #11
Message was sent while issue was closed.
Change committed as 161327

Powered by Google App Engine
This is Rietveld 408576698