Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 542893003: Add the frame provider base class used in cast media. (Closed)

Created:
6 years, 3 months ago by damienv1
Modified:
6 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add the frame provider base class used in cast media. Also add an adapter from the Chrome media DemuxerStream to the CodedFrameProvider. BUG=408189 Committed: https://crrev.com/e69b9325c720a85cc36b80432349f581b0758d2c Cr-Commit-Position: refs/heads/master@{#293624}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Do not use: scoped_refptr operator T* (disabled recently). #

Total comments: 6

Patch Set 4 : Fix CR comments from patch set #3 + Rebase. #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+662 lines, -3 lines) Patch
A chromecast/media/cma/base/coded_frame_provider.h View 1 2 3 1 chunk +51 lines, -0 lines 0 comments Download
A + chromecast/media/cma/base/coded_frame_provider.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
A chromecast/media/cma/filters/demuxer_stream_adapter.h View 1 2 3 4 1 chunk +85 lines, -0 lines 0 comments Download
A chromecast/media/cma/filters/demuxer_stream_adapter.cc View 1 2 3 4 1 chunk +182 lines, -0 lines 0 comments Download
A chromecast/media/cma/filters/demuxer_stream_adapter_unittest.cc View 1 2 3 1 chunk +324 lines, -0 lines 0 comments Download
M chromecast/media/media.gyp View 1 3 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
damienv1
Please take a look. Thanks !
6 years, 3 months ago (2014-09-05 02:24:52 UTC) #2
damienv1
https://codereview.chromium.org/542893003/diff/20001/chromecast/media/cma/base/coded_frame_provider.h File chromecast/media/cma/base/coded_frame_provider.h (right): https://codereview.chromium.org/542893003/diff/20001/chromecast/media/cma/base/coded_frame_provider.h#newcode25 chromecast/media/cma/base/coded_frame_provider.h:25: const ::media::VideoDecoderConfig&)> ReadCb; ReadCB https://codereview.chromium.org/542893003/diff/20001/chromecast/media/cma/filters/demuxer_stream_adapter_unittest.cc File chromecast/media/cma/filters/demuxer_stream_adapter_unittest.cc (right): https://codereview.chromium.org/542893003/diff/20001/chromecast/media/cma/filters/demuxer_stream_adapter_unittest.cc#newcode57 ...
6 years, 3 months ago (2014-09-05 20:15:48 UTC) #3
lcwu1
LGTM with fixing your own comments. :-)
6 years, 3 months ago (2014-09-05 21:06:17 UTC) #4
damienv1
https://codereview.chromium.org/542893003/diff/20001/chromecast/media/cma/base/coded_frame_provider.h File chromecast/media/cma/base/coded_frame_provider.h (right): https://codereview.chromium.org/542893003/diff/20001/chromecast/media/cma/base/coded_frame_provider.h#newcode25 chromecast/media/cma/base/coded_frame_provider.h:25: const ::media::VideoDecoderConfig&)> ReadCb; On 2014/09/05 20:15:48, damienv1 wrote: > ...
6 years, 3 months ago (2014-09-05 21:15:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/damienv@chromium.org/542893003/60001
6 years, 3 months ago (2014-09-05 22:07:52 UTC) #7
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 09:29:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/damienv@chromium.org/542893003/60001
6 years, 3 months ago (2014-09-06 17:00:25 UTC) #11
commit-bot: I haz the power
Committed patchset #5 (id:60001) as dc0617807ef9d856ac4b4b550a61dcde3cac13c8
6 years, 3 months ago (2014-09-06 18:55:12 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:42:55 UTC) #13
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/e69b9325c720a85cc36b80432349f581b0758d2c
Cr-Commit-Position: refs/heads/master@{#293624}

Powered by Google App Engine
This is Rietveld 408576698