Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 542883004: Cast: Merge common functionality from audio/video sender into frame_sender. (Closed)

Created:
6 years, 3 months ago by hubbe
Modified:
6 years, 3 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cast: Merge common functionality from audio/video sender into frame_sender. To make things simpler, also make congestion control into an interface with fixed and adaptive implementations. BUG=405622 Committed: https://crrev.com/47581b1fd39e86c350d90a843b510e9f6b79003e Cr-Commit-Position: refs/heads/master@{#293630}

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+414 lines, -454 lines) Patch
M media/cast/sender/audio_sender.h View 1 chunk +5 lines, -10 lines 0 comments Download
M media/cast/sender/audio_sender.cc View 4 chunks +15 lines, -139 lines 0 comments Download
M media/cast/sender/congestion_control.h View 1 chunk +15 lines, -54 lines 0 comments Download
M media/cast/sender/congestion_control.cc View 10 chunks +136 lines, -21 lines 0 comments Download
M media/cast/sender/congestion_control_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/sender/frame_sender.h View 7 chunks +30 lines, -2 lines 0 comments Download
M media/cast/sender/frame_sender.cc View 2 chunks +191 lines, -1 line 0 comments Download
M media/cast/sender/video_sender.h View 1 chunk +4 lines, -23 lines 0 comments Download
M media/cast/sender/video_sender.cc View 5 chunks +17 lines, -203 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
hubbe
6 years, 3 months ago (2014-09-05 06:45:39 UTC) #2
Alpha Left Google
lgtm
6 years, 3 months ago (2014-09-05 19:41:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hubbe@chromium.org/542883004/1
6 years, 3 months ago (2014-09-05 19:42:15 UTC) #5
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-09-05 20:46:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hubbe@chromium.org/542883004/20001
6 years, 3 months ago (2014-09-05 21:12:37 UTC) #9
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 03:14:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hubbe@chromium.org/542883004/20001
6 years, 3 months ago (2014-09-06 19:45:31 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 4ae3edf11a6fe7352719a349e9e93b724c319526
6 years, 3 months ago (2014-09-06 19:46:31 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:43:11 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/47581b1fd39e86c350d90a843b510e9f6b79003e
Cr-Commit-Position: refs/heads/master@{#293630}

Powered by Google App Engine
This is Rietveld 408576698