Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 542883003: GN: Make content and content_shell work when !enable_plugins (Closed)

Created:
6 years, 3 months ago by jamesr
Modified:
6 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

GN: Make content and content_shell work when !enable_plugins The android build has enable_plugins=false, so this gets the linux !enable_plugins build working to get android closer. R=brettw@chromium.org Committed: https://crrev.com/5008174cca5093531fbfd1f2a6df62e1196f0f4e Cr-Commit-Position: refs/heads/master@{#293892}

Patch Set 1 #

Patch Set 2 : make content work on linux with enable_plugins=0 #

Patch Set 3 : content_shell too #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -14 lines) Patch
M content/BUILD.gn View 1 2 3 4 2 chunks +4 lines, -1 line 0 comments Download
M content/child/BUILD.gn View 1 2 3 2 chunks +26 lines, -11 lines 0 comments Download
M content/renderer/BUILD.gn View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download
M content/shell/BUILD.gn View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M content/test/BUILD.gn View 1 2 3 4 3 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
jamesr
PTAL
6 years, 3 months ago (2014-09-05 17:42:46 UTC) #1
brettw
lgtm
6 years, 3 months ago (2014-09-05 17:48:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/542883003/60001
6 years, 3 months ago (2014-09-05 18:02:47 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/2526)
6 years, 3 months ago (2014-09-05 19:00:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/542883003/60001
6 years, 3 months ago (2014-09-05 19:48:37 UTC) #8
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 06:07:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/542883003/60001
6 years, 3 months ago (2014-09-07 22:24:37 UTC) #12
commit-bot: I haz the power
Failed to apply patch for content/BUILD.gn: While running git apply --index -p1; error: patch failed: ...
6 years, 3 months ago (2014-09-07 22:24:56 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/542883003/80001
6 years, 3 months ago (2014-09-09 06:55:00 UTC) #16
commit-bot: I haz the power
Committed patchset #5 (id:80001) as 321dee618e4407eb084aa5497af206c5ae0bbf9a
6 years, 3 months ago (2014-09-09 07:56:10 UTC) #17
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:51:52 UTC) #18
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/5008174cca5093531fbfd1f2a6df62e1196f0f4e
Cr-Commit-Position: refs/heads/master@{#293892}

Powered by Google App Engine
This is Rietveld 408576698