Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Issue 542863007: Remove hasContentsLayer and isMainFrameRenderViewLayer from CLM (Closed)

Created:
6 years, 3 months ago by pdr.
Modified:
6 years, 3 months ago
Reviewers:
kouhei (in TOK)
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, abarth-chromium, jchaffraix+rendering, pdr., rune+blink
Project:
blink
Visibility:
Public.

Description

Remove hasContentsLayer and isMainFrameRenderViewLayer from CLM This patch removes some deadcode from CompositedLayerMapping: 1) hasContentsLayer - this function name was confusing. 2) isMainFrameRenderViewLayer - state is now all within CLM. No new tests, no change in behavior. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181526

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M Source/core/rendering/compositing/CompositedLayerMapping.h View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pdr.
6 years, 3 months ago (2014-09-07 05:00:22 UTC) #2
kouhei (in TOK)
lgtm
6 years, 3 months ago (2014-09-07 13:53:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/542863007/1
6 years, 3 months ago (2014-09-07 13:54:20 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-07 16:18:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181526

Powered by Google App Engine
This is Rietveld 408576698