content/browser/media/capture/web_contents_audio_input_stream.h - Issue 542863004: Site Isolation: RenderView-->RenderFrame for WebContentsVideoCaptureDevice and WebContentsAudioInpu…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/capture/web_contents_audio_input_stream.h

Issue 542863004: Site Isolation: RenderView-->RenderFrame for WebContentsVideoCaptureDevice and WebContentsAudioInpu… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix comment/naming, per review suggestions. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/media/capture/audio_mirroring_manager_unittest.cc ('k') | content/browser/media/capture/web_contents_audio_input_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/media/capture/web_contents_audio_input_stream.h

diff --git a/content/browser/media/capture/web_contents_audio_input_stream.h b/content/browser/media/capture/web_contents_audio_input_stream.h

index 9bdc91493fbec235b2de9785e5fe9f67f51c6747..b746500597bfad368367db39df5d2a67edf7ed70 100644

--- a/content/browser/media/capture/web_contents_audio_input_stream.h

+++ b/content/browser/media/capture/web_contents_audio_input_stream.h

@@ -3,15 +3,12 @@

// found in the LICENSE file.

// An AudioInputStream which provides a loop-back of all audio output generated

-// by the RenderView associated with a WebContents instance. The single stream

-// of data is produced by format-converting and mixing all audio output from a

-// RenderView. In other words, WebContentsAudioInputStream provides tab-level

+// by the entire RenderFrame tree associated with a WebContents instance. The

+// single stream of data is produced by format-converting and mixing all audio

+// output streams. As the RenderFrameHost tree mutates (e.g., due to page

+// navigations, or crashes/reloads), the stream will continue without

+// interruption. In other words, WebContentsAudioInputStream provides tab-level

// audio mirroring.

-//

-// The implementation observes a WebContents instance (which represents a

-// browser tab) so that it can track the replacement of RenderViews due to

-// navigation, crash/reload, etc. events; and take appropriate actions to

-// provide a seamless, uninterrupted mirroring experience.

#ifndef CONTENT_BROWSER_MEDIA_CAPTURE_WEB_CONTENTS_AUDIO_INPUT_STREAM_H_

#define CONTENT_BROWSER_MEDIA_CAPTURE_WEB_CONTENTS_AUDIO_INPUT_STREAM_H_