Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Issue 542863002: Add more casts. (Closed)

Created:
6 years, 3 months ago by Nico
Modified:
6 years, 3 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add more casts. Fixes several clang/win errors like ..\..\sandbox\win\sandbox_poc\pocdll\registry.cc(24,10) : error(clang): value of type 'HKEY' (aka 'HKEY__ *') is not implicitly convertible to 'LONG_PTR' (aka 'long') case HKEY_USERS: ^~~~~~~~~~ Also fix a format string warning while here. No intended behavior change. BUG=82385 Committed: https://crrev.com/8f60682031435c51ccf192d7b634335124822c03 Cr-Commit-Position: refs/heads/master@{#293540}

Patch Set 1 #

Patch Set 2 : also warning #

Patch Set 3 : bleh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M sandbox/win/sandbox_poc/pocdll/registry.cc View 1 2 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Nico
This whole file is from initial.commit, so not sure why the cast was there in ...
6 years, 3 months ago (2014-09-04 23:55:56 UTC) #2
Nico
Oh, because cl says " error C2450: switch expression of type 'const HKEY' is illegal" ...
6 years, 3 months ago (2014-09-04 23:56:34 UTC) #3
Nico
Ok, PTAL
6 years, 3 months ago (2014-09-05 00:05:51 UTC) #4
cpu_(ooo_6.6-7.5)
lgtm
6 years, 3 months ago (2014-09-05 15:53:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/542863002/40001
6 years, 3 months ago (2014-09-05 16:00:08 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001) as ca2ae65f53c3dfb51bbe5f95ce862a146e82151f
6 years, 3 months ago (2014-09-05 17:01:43 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:40:12 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8f60682031435c51ccf192d7b634335124822c03
Cr-Commit-Position: refs/heads/master@{#293540}

Powered by Google App Engine
This is Rietveld 408576698