Source/bindings/v8/custom/V8HistoryCustom.cpp - Issue 54283002: Rename |args| to |info| in V8 bindings

Unified Diff: Source/bindings/v8/custom/V8HistoryCustom.cpp

Issue 54283002: Rename |args| to |info| in V8 bindings (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « Source/bindings/v8/custom/V8HTMLPlugInElementCustom.cpp ('k') | Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/v8/custom/V8HistoryCustom.cpp

diff --git a/Source/bindings/v8/custom/V8HistoryCustom.cpp b/Source/bindings/v8/custom/V8HistoryCustom.cpp

index 8e3936c65451f66e633966e503bba8f0240754ae..d5e7d357aa4744a8f6cca3fdec270cab685e0a13 100644

--- a/Source/bindings/v8/custom/V8HistoryCustom.cpp

+++ b/Source/bindings/v8/custom/V8HistoryCustom.cpp

@@ -59,37 +59,37 @@ void V8History::stateAttributeGetterCustom(v8::Local<v8::String> name, const v8:

v8SetReturnValue(info, value);

}

-void V8History::pushStateMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& args)

+void V8History::pushStateMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)

{

bool didThrow = false;

- RefPtr<SerializedScriptValue> historyState = SerializedScriptValue::create(args[0], 0, 0, didThrow, args.GetIsolate());

+ RefPtr<SerializedScriptValue> historyState = SerializedScriptValue::create(info[0], 0, 0, didThrow, info.GetIsolate());

if (didThrow)

return;

- V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<WithUndefinedOrNullCheck>, title, args[1]);

- V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<WithUndefinedOrNullCheck>, url, argumentOrNull(args, 2));

+ V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<WithUndefinedOrNullCheck>, title, info[1]);

+ V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<WithUndefinedOrNullCheck>, url, argumentOrNull(info, 2));

- ExceptionState es(args.GetIsolate());

- History* history = V8History::toNative(args.Holder());

+ ExceptionState es(info.GetIsolate());

+ History* history = V8History::toNative(info.Holder());

history->stateObjectAdded(historyState.release(), title, url, SameDocumentNavigationPushState, es);

- args.Holder()->DeleteHiddenValue(V8HiddenPropertyName::state(args.GetIsolate()));

+ info.Holder()->DeleteHiddenValue(V8HiddenPropertyName::state(info.GetIsolate()));

es.throwIfNeeded();

}

-void V8History::replaceStateMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& args)

+void V8History::replaceStateMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)

{