Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Unified Diff: Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp

Issue 54283002: Rename |args| to |info| in V8 bindings (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp
diff --git a/Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp b/Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp
index cc58eda780c361909c8cce31da547ab3382bcabf..4994e01021c2d4c69c290182bb35b9dbf34f4f07 100644
--- a/Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp
+++ b/Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp
@@ -64,28 +64,28 @@ static void getNamedItems(HTMLOptionsCollection* collection, const AtomicString&
v8SetReturnValueFast(callbackInfo, NamedNodesCollection::create(namedItems), collection);
}
-void V8HTMLOptionsCollection::namedItemMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& args)
+void V8HTMLOptionsCollection::namedItemMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
{
- V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, name, args[0]);
- HTMLOptionsCollection* imp = V8HTMLOptionsCollection::toNative(args.Holder());
- getNamedItems(imp, name, args);
+ V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, name, info[0]);
+ HTMLOptionsCollection* imp = V8HTMLOptionsCollection::toNative(info.Holder());
+ getNamedItems(imp, name, info);
}
-void V8HTMLOptionsCollection::addMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& args)
+void V8HTMLOptionsCollection::addMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
{
- if (!V8HTMLOptionElement::HasInstance(args[0], args.GetIsolate(), worldType(args.GetIsolate()))) {
- setDOMException(TypeMismatchError, args.GetIsolate());
+ if (!V8HTMLOptionElement::HasInstance(info[0], info.GetIsolate(), worldType(info.GetIsolate()))) {
+ setDOMException(TypeMismatchError, info.GetIsolate());
return;
}
- HTMLOptionsCollection* imp = V8HTMLOptionsCollection::toNative(args.Holder());
- HTMLOptionElement* option = V8HTMLOptionElement::toNative(v8::Handle<v8::Object>(v8::Handle<v8::Object>::Cast(args[0])));
+ HTMLOptionsCollection* imp = V8HTMLOptionsCollection::toNative(info.Holder());
+ HTMLOptionElement* option = V8HTMLOptionElement::toNative(v8::Handle<v8::Object>(v8::Handle<v8::Object>::Cast(info[0])));
- ExceptionState es(args.GetIsolate());
- if (args.Length() < 2)
+ ExceptionState es(info.GetIsolate());
+ if (info.Length() < 2)
imp->add(option, es);
else {
bool ok;
- V8TRYCATCH_VOID(int, index, toInt32(args[1], ok));
+ V8TRYCATCH_VOID(int, index, toInt32(info[1], ok));
if (!ok)
es.throwDOMException(TypeMismatchError, ExceptionMessages::failedToExecute("add", "HTMLOptionsCollection", "The index provided could not be interpreted as an integer."));
else

Powered by Google App Engine
This is Rietveld 408576698