Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Side by Side Diff: Source/bindings/v8/V8Binding.cpp

Issue 54283002: Rename |args| to |info| in V8 bindings (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/bindings/v8/V8Binding.h ('k') | Source/bindings/v8/V8LazyEventListener.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 v8::Handle<v8::Value> v8Array(PassRefPtr<DOMStringList> stringList, v8::Isolate* isolate) 128 v8::Handle<v8::Value> v8Array(PassRefPtr<DOMStringList> stringList, v8::Isolate* isolate)
129 { 129 {
130 if (!stringList) 130 if (!stringList)
131 return v8::Array::New(); 131 return v8::Array::New();
132 v8::Local<v8::Array> result = v8::Array::New(stringList->length()); 132 v8::Local<v8::Array> result = v8::Array::New(stringList->length());
133 for (unsigned i = 0; i < stringList->length(); ++i) 133 for (unsigned i = 0; i < stringList->length(); ++i)
134 result->Set(v8::Integer::New(i, isolate), v8String(stringList->item(i), isolate)); 134 result->Set(v8::Integer::New(i, isolate), v8String(stringList->item(i), isolate));
135 return result; 135 return result;
136 } 136 }
137 137
138 Vector<v8::Handle<v8::Value> > toVectorOfArguments(const v8::FunctionCallbackInf o<v8::Value>& args) 138 Vector<v8::Handle<v8::Value> > toVectorOfArguments(const v8::FunctionCallbackInf o<v8::Value>& info)
139 { 139 {
140 Vector<v8::Handle<v8::Value> > result; 140 Vector<v8::Handle<v8::Value> > result;
141 size_t length = args.Length(); 141 size_t length = info.Length();
142 for (size_t i = 0; i < length; ++i) 142 for (size_t i = 0; i < length; ++i)
143 result.append(args[i]); 143 result.append(info[i]);
144 return result; 144 return result;
145 } 145 }
146 146
147 PassRefPtr<NodeFilter> toNodeFilter(v8::Handle<v8::Value> callback, v8::Isolate* isolate) 147 PassRefPtr<NodeFilter> toNodeFilter(v8::Handle<v8::Value> callback, v8::Isolate* isolate)
148 { 148 {
149 RefPtr<NodeFilter> filter = NodeFilter::create(); 149 RefPtr<NodeFilter> filter = NodeFilter::create();
150 150
151 // FIXME: Should pass in appropriate creationContext 151 // FIXME: Should pass in appropriate creationContext
152 v8::Handle<v8::Object> filterWrapper = toV8(filter, v8::Handle<v8::Object>() , isolate).As<v8::Object>(); 152 v8::Handle<v8::Object> filterWrapper = toV8(filter, v8::Handle<v8::Object>() , isolate).As<v8::Object>();
153 153
(...skipping 449 matching lines...) Expand 10 before | Expand all | Expand 10 after
603 return mainThreadIsolate(); 603 return mainThreadIsolate();
604 return v8::Isolate::GetCurrent(); 604 return v8::Isolate::GetCurrent();
605 } 605 }
606 606
607 v8::Isolate* toIsolate(Frame* frame) 607 v8::Isolate* toIsolate(Frame* frame)
608 { 608 {
609 return frame->script().isolate(); 609 return frame->script().isolate();
610 } 610 }
611 611
612 } // namespace WebCore 612 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/v8/V8Binding.h ('k') | Source/bindings/v8/V8LazyEventListener.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698