Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 542823002: [Password Generation] Update text for generation popup. (Closed)

Created:
6 years, 3 months ago by Garrett Casto
Modified:
6 years, 3 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, benquan, tfarina, Dane Wallinga, dyu1, rouslan+autofillwatch_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, Ilya Sherman, mkwst+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Password Generation] Update text for generation popup. BUG=318977 Committed: https://crrev.com/d2b6dd2a88da2815b79d6a4993cf13f182b77c62 Cr-Commit-Position: refs/heads/master@{#293597}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M chrome/app/chromium_strings.grd View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Garrett Casto
6 years, 3 months ago (2014-09-04 21:02:29 UTC) #2
Evan Stade
lgtm
6 years, 3 months ago (2014-09-04 21:46:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gcasto@chromium.org/542823002/1
6 years, 3 months ago (2014-09-04 23:43:29 UTC) #5
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-09-05 04:47:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gcasto@chromium.org/542823002/1
6 years, 3 months ago (2014-09-05 23:54:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 2e2a7b284471739fcc715cc96eb49670f16f9062
6 years, 3 months ago (2014-09-06 00:48:20 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:42:04 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d2b6dd2a88da2815b79d6a4993cf13f182b77c62
Cr-Commit-Position: refs/heads/master@{#293597}

Powered by Google App Engine
This is Rietveld 408576698