Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Unified Diff: net/disk_cache/disk_cache_test_base.cc

Issue 542733002: Remove void** from disk_cache interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix EnumerateAndMatchKeys Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/disk_cache/disk_cache_test_base.cc
diff --git a/net/disk_cache/disk_cache_test_base.cc b/net/disk_cache/disk_cache_test_base.cc
index d0f984256ad425113fb440d5b4fb4017b8e9cbe5..c3d94e6ac9ae30249444d35dd4e7aa3f21792852 100644
--- a/net/disk_cache/disk_cache_test_base.cc
+++ b/net/disk_cache/disk_cache_test_base.cc
@@ -52,6 +52,20 @@ void DiskCacheTest::TearDown() {
base::RunLoop().RunUntilIdle();
}
+DiskCacheTestWithCache::TestIterator::TestIterator(
+ scoped_ptr<disk_cache::Backend::Iterator> iterator)
+ : iterator_(iterator.Pass()) {
+}
+
+DiskCacheTestWithCache::TestIterator::~TestIterator() {}
+
+int DiskCacheTestWithCache::TestIterator::OpenNextEntry(
+ disk_cache::Entry** next_entry) {
+ net::TestCompletionCallback cb;
+ int rv = iterator_->OpenNextEntry(next_entry, cb.callback());
+ return cb.GetResult(rv);
+}
+
DiskCacheTestWithCache::DiskCacheTestWithCache()
: cache_impl_(NULL),
simple_cache_impl_(NULL),
@@ -153,11 +167,9 @@ int DiskCacheTestWithCache::DoomEntriesSince(const base::Time initial_time) {
return cb.GetResult(rv);
}
-int DiskCacheTestWithCache::OpenNextEntry(void** iter,
- disk_cache::Entry** next_entry) {
- net::TestCompletionCallback cb;
- int rv = cache_->OpenNextEntry(iter, next_entry, cb.callback());
- return cb.GetResult(rv);
+scoped_ptr<DiskCacheTestWithCache::TestIterator>
+ DiskCacheTestWithCache::CreateIterator() {
+ return scoped_ptr<TestIterator>(new TestIterator(cache_->CreateIterator()));
}
void DiskCacheTestWithCache::FlushQueueForTest() {

Powered by Google App Engine
This is Rietveld 408576698