Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: net/http/mock_http_cache.cc

Issue 542733002: Remove void** from disk_cache interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: now even less dumb Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/mock_http_cache.cc
diff --git a/net/http/mock_http_cache.cc b/net/http/mock_http_cache.cc
index a91b2c1aa83107c737b67aa40ab064b1ef44f1f3..5c27eb6d5e8bc5611d36e16c05b7c16fb128a38f 100644
--- a/net/http/mock_http_cache.cc
+++ b/net/http/mock_http_cache.cc
@@ -457,12 +457,16 @@ int MockDiskCache::DoomEntriesSince(const base::Time initial_time,
return net::ERR_NOT_IMPLEMENTED;
}
-int MockDiskCache::OpenNextEntry(void** iter, disk_cache::Entry** next_entry,
- const net::CompletionCallback& callback) {
- return net::ERR_NOT_IMPLEMENTED;
-}
-
-void MockDiskCache::EndEnumeration(void** iter) {
+scoped_ptr<disk_cache::Backend::Iterator> MockDiskCache::CreateIterator() {
+ class NotImplementedIterator : public Iterator {
+ public:
+ virtual int OpenNextEntry(
+ disk_cache::Entry** next_entry,
+ const net::CompletionCallback& callback) OVERRIDE {
+ return net::ERR_NOT_IMPLEMENTED;
+ }
+ };
+ return scoped_ptr<Iterator>(new NotImplementedIterator());
}
void MockDiskCache::GetStats(

Powered by Google App Engine
This is Rietveld 408576698