net/disk_cache/blockfile/backend_impl_v3.h - Issue 542733002: Remove void** from disk_cache interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/disk_cache/blockfile/backend_impl_v3.h

Issue 542733002: Remove void** from disk_cache interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: narrow given upstream Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/disk_cache/blockfile/backend_impl_v3.h

diff --git a/net/disk_cache/blockfile/backend_impl_v3.h b/net/disk_cache/blockfile/backend_impl_v3.h

index b57bb8914e6a4a4600508588a14b90b526cdc064..106d892afa3efa84b4c5d037af32aadcba1c6822 100644

--- a/net/disk_cache/blockfile/backend_impl_v3.h

+++ b/net/disk_cache/blockfile/backend_impl_v3.h

@@ -186,9 +186,8 @@ class NET_EXPORT_PRIVATE BackendImplV3 : public Backend {

const CompletionCallback& callback) OVERRIDE;

virtual int DoomEntriesSince(base::Time initial_time,

const CompletionCallback& callback) OVERRIDE;

- virtual int OpenNextEntry(void** iter, Entry** next_entry,

+ virtual int OpenNextEntry(Iterator* iter, Entry** next_entry,

const CompletionCallback& callback) OVERRIDE;

- virtual void EndEnumeration(void** iter) OVERRIDE;

virtual void GetStats(StatsItems* stats) OVERRIDE;

virtual void OnExternalCacheHit(const std::string& key) OVERRIDE;