Remove void** from disk_cache interface.

net/disk_cache/blockfile/backend_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/disk_cache/blockfile/backend_impl.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/files/file.h"
 #include "base/files/file_path.h"
@@ skipping 1232 matching lines @@
   return net::ERR_IO_PENDING;
 }
 
 int BackendImpl::DoomEntriesSince(const base::Time initial_time,
                                   const CompletionCallback& callback) {
   DCHECK(!callback.is_null());
   background_queue_.DoomEntriesSince(initial_time, callback);
   return net::ERR_IO_PENDING;
 }
 
-int BackendImpl::OpenNextEntry(void** iter, Entry** next_entry,
-                               const CompletionCallback& callback) {
-  DCHECK(!callback.is_null());
-  background_queue_.OpenNextEntry(iter, next_entry, callback);
-  return net::ERR_IO_PENDING;
-}
 
-void BackendImpl::EndEnumeration(void** iter) {
-  background_queue_.EndEnumeration(*iter);
-  *iter = NULL;
+scoped_ptr<Backend::Iterator> BackendImpl::CreateIterator() {
+  class BackendIterator FINAL : public Backend::Iterator {

[rvargas (doing something else), 2014/09/18 02:32:11]

declare this outside the method

[rvargas (doing something else), 2014/09/18 02:32:12]

Is there any real value to annotate this class with FINAL?

[gavinp, 2014/09/18 18:13:04]

Done.

[gavinp, 2014/09/18 18:13:04]

No. Removed.

+   public:
+    explicit BackendIterator(base::WeakPtr<InFlightBackendIO> background_queue)
+        : background_queue_(background_queue), data_(NULL) {}
+
+    virtual int OpenNextEntry(
+        Entry** next_entry,
+        const net::CompletionCallback& callback) OVERRIDE {
+      if (!background_queue_)
+        return net::ERR_FAILED;
+      background_queue_->OpenNextEntry(&data_, next_entry, callback);
+      return net::ERR_IO_PENDING;
+    }
+
+   private:
+    const base::WeakPtr<InFlightBackendIO> background_queue_;
+    void* data_;
+  };
+
+  return
+      scoped_ptr<Backend::Iterator>(new BackendIterator(GetBackgroundQueue()));
 }
 
 void BackendImpl::GetStats(StatsItems* stats) {
   if (disabled_)
     return;
 
   std::pair<std::string, std::string> item;
 
   item.first = "Entries";
   item.second = base::StringPrintf("%d", data_->header.num_entries);
@@ skipping 793 matching lines @@
     if (total_memory > kMaxBuffersSize || total_memory <= 0)
       total_memory = kMaxBuffersSize;
 
     done = true;
   }
 
   return static_cast<int>(total_memory);
 }
 
 }  // namespace disk_cache