Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: Source/core/editing/markup.cpp

Issue 54273007: Use more references in ContainerNode code (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix crashes Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/editing/markup.cpp
diff --git a/Source/core/editing/markup.cpp b/Source/core/editing/markup.cpp
index af001a849255dada4bfbb5fcf04e9e104307c7ef..2a644bebb6f51a9d2556c1248a6d63400825e522 100644
--- a/Source/core/editing/markup.cpp
+++ b/Source/core/editing/markup.cpp
@@ -710,7 +710,7 @@ PassRefPtr<DocumentFragment> createFragmentFromMarkupWithContext(Document& docum
// FIXME: It's not clear what this code is trying to do. It puts nodes as direct children of a
// Document that are not normally allowed by using the parser machinery.
- taggedDocument->parserTakeAllChildrenFrom(taggedFragment.get());
+ taggedDocument->parserTakeAllChildrenFrom(*taggedFragment);
RefPtr<Node> nodeBeforeContext;
RefPtr<Node> nodeAfterContext;
@@ -731,7 +731,7 @@ PassRefPtr<DocumentFragment> createFragmentFromMarkupWithContext(Document& docum
if (specialCommonAncestor)
fragment->appendChild(specialCommonAncestor);
else
- fragment->parserTakeAllChildrenFrom(toContainerNode(commonAncestor));
+ fragment->parserTakeAllChildrenFrom(toContainerNode(*commonAncestor));
trimFragment(fragment.get(), nodeBeforeContext.get(), nodeAfterContext.get());

Powered by Google App Engine
This is Rietveld 408576698