Source/core/editing/ApplyStyleCommand.cpp - Issue 54273007: Use more references in ContainerNode code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/ApplyStyleCommand.cpp

Issue 54273007: Use more references in ContainerNode code (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix crashes Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/ApplyStyleCommand.cpp

diff --git a/Source/core/editing/ApplyStyleCommand.cpp b/Source/core/editing/ApplyStyleCommand.cpp

index 35656f9f6e9f136f3de0786e5e8ac60f8fe88844..f221f34d2da4fcc4036f6bbce64614c5f71a9be7 100644

--- a/Source/core/editing/ApplyStyleCommand.cpp

+++ b/Source/core/editing/ApplyStyleCommand.cpp

@@ -1028,7 +1028,7 @@ void ApplyStyleCommand::pushDownInlineStyleAroundNode(EditingStyle* style, Node*

Vector<RefPtr<Element> > elementsToPushDown;

while (current && current != targetNode && current->contains(targetNode)) {

NodeVector currentChildren;

- getChildNodes(current.get(), currentChildren);

+ getChildNodes(*current, currentChildren);

RefPtr<Element> styledElement;

if (current->isStyledElement() && isStyledInlineElementToRemove(toElement(current))) {

styledElement = toElement(current);