Source/core/dom/Document.h - Issue 54273007: Use more references in ContainerNode code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Document.h

Issue 54273007: Use more references in ContainerNode code (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix crashes Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/Document.h

diff --git a/Source/core/dom/Document.h b/Source/core/dom/Document.h

index b187eb845edd070f81ae32f7480f302b40121f71..c81906e02cfe6415ff6b05adb28b8886e97e8731 100644

--- a/Source/core/dom/Document.h

+++ b/Source/core/dom/Document.h

@@ -650,7 +650,7 @@ public:

void nodeChildrenWillBeRemoved(ContainerNode*);

// nodeWillBeRemoved is only safe when removing one node at a time.

void nodeWillBeRemoved(Node&);

- bool canReplaceChild(Node* newChild, Node* oldChild);

+ bool canReplaceChild(Node& newChild, Node& oldChild);

void didInsertText(Node*, unsigned offset, unsigned length);

void didRemoveText(Node*, unsigned offset, unsigned length);