Add SettingsOverridesAPI dependence on TemplateURLServiceFactory.

Add SettingsOverridesAPI dependence on TemplateURLServiceFactory.

BUG=267510
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233434

[vasilii, 2013-10-31 13:49:31]

Hi,

please review the CL.

[not at google - send to devlin, 2013-10-31 14:56:11]

https://codereview.chromium.org/54273004/diff/1/chrome/browser/extensions/api...
File chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc
(right):

https://codereview.chromium.org/54273004/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc:218:
DependsOn(ExtensionSystemFactory::GetInstance());
I don't see an ExtensionSystem dependency here, but I do see some ExtensionPrefs
related ones.

[vasilii, 2013-10-31 15:06:47]

https://codereview.chromium.org/54273004/diff/1/chrome/browser/extensions/api...
File chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc
(right):

https://codereview.chromium.org/54273004/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc:218:
DependsOn(ExtensionSystemFactory::GetInstance());
On 2013/10/31 14:56:12, kalman wrote:
> I don't see an ExtensionSystem dependency here, but I do see some
ExtensionPrefs
> related ones.

Done.

[not at google - send to devlin, 2013-10-31 15:22:04]

lgtm

https://codereview.chromium.org/54273004/diff/100001/chrome/browser/extension...
File chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc
(right):

https://codereview.chromium.org/54273004/diff/100001/chrome/browser/extension...
chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc:93:
PreferenceAPI::Get(profile_)->SetExtensionControlledPref(
Do you need to add a dependency to PreferenceAPI as well?

[vasilii, 2013-10-31 15:39:26]

https://codereview.chromium.org/54273004/diff/100001/chrome/browser/extension...
File chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc
(right):

https://codereview.chromium.org/54273004/diff/100001/chrome/browser/extension...
chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc:93:
PreferenceAPI::Get(profile_)->SetExtensionControlledPref(
On 2013/10/31 15:22:04, kalman wrote:
> Do you need to add a dependency to PreferenceAPI as well?

Done.

[commit-bot: I haz the power, 2013-10-31 16:48:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vasilii@chromium.org/54273004/180001

[commit-bot: I haz the power, 2013-10-31 17:39:57]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[battre, 2013-11-06 21:56:59]

On 2013/10/31 17:39:57, I haz the power (commit-bot) wrote:
> Sorry for I got bad news for ya.
> Compile failed with a clobber build on linux_chromeos_clang.
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
> Your code is likely broken or HEAD is junk. Please ensure your
> code is not broken then alert the build sheriffs.
> Look at the try server FAQ for more details.

It looks like this compiler failure was unrelated, so I will try to re-submit.

[commit-bot: I haz the power, 2013-11-06 22:03:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vasilii@chromium.org/54273004/180001

[commit-bot: I haz the power, 2013-11-07 00:31:15]

Change committed as 233434