Issue 54273002: Revert piece of "De-duplicate job_settings parsing code." r231501

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 54273002: Revert piece of "De-duplicate job_settings parsing code." r231501 (Closed)

Created:
7 years, 1 month ago by Vitaly Buka (NO REVIEWS)

Modified:
7 years, 1 month ago

Reviewers:
Noam Samuel

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert piece of "De-duplicate job_settings parsing code." r231501 UseDefaultSettingsis call is not necessary. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232371

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	printing/printing_context.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	printing/printing_context_no_system_dialog.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/54273002/1

7 years, 1 month ago (2013-10-31 08:18:58 UTC) #2

commit-bot: I haz the power

Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=95634

7 years, 1 month ago (2013-10-31 11:15:34 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/54273002/1

7 years, 1 month ago (2013-10-31 17:48:24 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/54273002/1

7 years, 1 month ago (2013-10-31 23:49:44 UTC) #6

Message was sent while issue was closed.

Change committed as 232371

Expand Messages | Collapse Messages